Skip to content
This repository has been archived by the owner on Oct 26, 2018. It is now read-only.

rename UPDATE_LOCATION to CALL_HISTORY_METHOD #265

Merged
merged 1 commit into from
Feb 6, 2016

Conversation

webmasterkai
Copy link
Contributor

Following comments on #259.

I'm not sure keeping the old name is worth the confusion generated by introducing two actions.

Especially now that we encourage calling history methods directly, people relying on the old action and thinking they don't need to change their analytics code will have broken code because direct history calls will not invoke the new action.

I think CALL_HISTORY_METHOD might be the best choice here. It makes it clear this is not intended for analytics.

Also, let's not forget the the name already changed once in the past...

  • UPDATE_PATH is now UPDATE_LOCATION.

timdorr added a commit that referenced this pull request Feb 6, 2016
rename UPDATE_LOCATION to CALL_HISTORY_METHOD
@timdorr timdorr merged commit a452791 into reactjs:synchronicity Feb 6, 2016
@webmasterkai
Copy link
Contributor Author

💋 Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants