This repository has been archived by the owner on Oct 26, 2018. It is now read-only.
Makes sure the state in the store matches the state in history when using SSR #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves some problems where they would be out of sync on the first render when using server side rendering. The location would be the same for both of them but the key would be different resulting in some strange behaviour. The application will now always dispatch a LOCATION_CHANGE on initial render. This was already done when not using server side rendering, meaning that the behaviour is similar between using server side rendering and not.
|
Any news? |
|
I don't have time at the moment to write tests but I believe the implementation is solid. Help here is appreciated. |
|
@dlmr These changes work for our project too, enabling the transition from server to client without a hitch. I'd love to have this PR land soon, could you help me figure out what the approach to tests should be so I can contribute with some? |
|
OK, let's do it! |
|
Out in 4.0.6. Sorry it took so long! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some problems where they would be out of sync on the first render when using server side rendering. The location would be the same for both of them but the
keywould be different resulting in some strange behaviour.The application will now always dispatch a
LOCATION_CHANGEon initial render. This was already done when not using server side rendering, meaning that the behaviour is similar between using server side rendering and not.I have tested this manually and it seems to work fine. I have unfortunately not enough time right now to add more tests.
I believe that this PR supersedes #412 and will probably address #444 and #429.