This repository was archived by the owner on Oct 26, 2018. It is now read-only.
Create test helper to improve tests #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Very nice! 👍 |
Member
There was a problem hiding this comment.
I think I like this. changeId is a case where it might be too much implementation detail to encode in tests.
This is one place where we lose information though. You aren't testing that history.pushState is actually called twice.
Collaborator
Author
There was a problem hiding this comment.
Ah, good catch, @jlongster. I'll fix asap.
Collaborator
Author
|
@jlongster This should cover it, I think. |
Member
|
Cool. (I was wrong in that the place that actually tested it was later in the file) |
jlongster
added a commit
that referenced
this pull request
Dec 5, 2015
Create test helper to improve tests
Member
|
I promise to look at the other PRs and resolve the devtools issues today or tomorrow! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this nicely cleaned up a couple of the tests. Plus it's easier to not specify the
changeIdwhile still keeping the tests easily readable.