This repository was archived by the owner on Oct 26, 2018. It is now read-only.
update comments and avoid early returns #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlongster
force-pushed
the
style-fixes
branch
from
59d5465 to
00034db
Compare
Member
Author
|
Going to merge this because there's another important PR I want to make after it |
jlongster
added a commit
that referenced
this pull request
Dec 6, 2015
update comments and avoid early returns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some info to the comments because I wanted to explain every detail as to how things work. I also change the code to remove early returns, as I think it is clearer.
Just opening a PR in case I made any mistakes, but I'd like to merge soon. All tests still pass.