Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

use history.push instead of history.pushState #85

Closed
wants to merge 1 commit into from

Conversation

gaboesquivel
Copy link

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 7, 2015

This doesn't work, as far as I can see. The push api is different from pushState, so just changing the name is not enough to get this to work. At least we need all the tests to still pass. You can run them using npm test.

@gaboesquivel
Copy link
Author

dammit, I hope it was just an method name change. Sorry about that, I'll check it out and squash the update.

@kimjoar
Copy link
Collaborator

kimjoar commented Dec 7, 2015

Actually, there's already a PR that's solving this problem (and a few other things at the same time): #89

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants