Fix outdated umd build (fixes #111) #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "preversion": "npm run lint && npm test && npm run bundle && git add dist/ && git commit -m 'Publish: build bower distribution'", | ||
| "prepublish": "npm run build", | ||
| "preversion": "npm run lint && npm test && npm run build && npm run bundle && git add dist/ && git commit -m 'Publish: build bower distribution'", | ||
| "prepublish": "npm run build && npm run bundle", |
There was a problem hiding this comment.
running bundle in prepublish looks redundant to me, because it is anyway run in preversion. Or do I miss something?
because the release flow is anyway
npm version patch
npm publish
git push --follow-tagsThere was a problem hiding this comment.
Agreed, I'll take that out. Admittedly, my reasoning was "it will probably go there in the future anyway." Which, in programming, is almost objectively bad reasoning :'D.
|
Good catch, thanks a lot! |
|
👍 My pleasure! Haha yeah that might be the only reliable way of finding out how many people are actively using this through bower. Which is actually kind of sad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #111. Figured I'd make a PR with my suggested fix. After merging, the version would need to be bumped (including git tag) and published to npm for the build to be picked up by both bower and npmcdn.