-
Notifications
You must be signed in to change notification settings - Fork 650
Move from TavisCI to GitHub Actions #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Was just temporarily enable for other branches for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Use Node.js 14 | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current active LTS version of Node is 16, so v16 seems to be better.
- name: Use Node.js 14 | |
uses: actions/setup-node@v2 | |
with: | |
node-version: 14 | |
- name: Use Node.js 16 | |
uses: actions/setup-node@v2 | |
with: | |
node-version: 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this PR was to move from Travis to GitHub actions. Travis was running on node 14. I think we should do this in a follow-up.
.github/workflows/ci.yml
Outdated
- run: yarn --cwd www | ||
- run: yarn test | ||
- run: npm run build | ||
- run: npm run semantic-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this wouldn't work on GitHub Actions because this requires tokens like NPM_TOKEN
and GITHUB_TOKEN
, which would be set on TravisCI.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Unfortunately, I don't have permission to set up semantic-release
.
@jquense Could you help us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I forgot to mention that an admin needs to setup secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about removing the script?
Personally, I think it's good to release a new version manually instead of doing it on CI. I don't have the permission though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to introduce some breaking changes like dropping IE support and removing PropTypes in the future. In that time, I'd like to release the breaking changes as a single major version, not separately.
But we can't do that because this script releases a new version automatically, so I'd like to remove running semantic-release
on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can collect breaking changes on an alpha
branch and merge that once it's ready. semantic-release
will create an alpha
release channel from that branch for test. We're doing that for @testing-library/react
and it has been working great so far.
Will re-open from this remote. Otherwise we'll not get a run. Once it's merged forks will trigger Actions. |
Example run: https://github.com/eps1lon/react-transition-group/runs/4298012167?check_suite_focus=true