Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check for unique redirect URLs #1

Closed
bvaughn opened this issue Oct 6, 2017 · 0 comments
Closed

Add CI check for unique redirect URLs #1

bvaughn opened this issue Oct 6, 2017 · 0 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

@sophiebits and I recently noticed that /docs/index.html redirected to /docs/accessibility.html rather than /docs/hello-world.html. This turned out to be because both /docs/hello-word.md and /docs/accessibility.md declared the redirect rule redirect_from: "docs/index.html". (Presumably this is because one was copied from the other without much thought about the redirect bit.)

We should add a check to gatsby-node.js that throws an error if it detects a duplicate redirect. This will cause the Netlify preview to fail and alert a PR reviewer that there's a problem.

bvaughn pushed a commit that referenced this issue Mar 29, 2018
createRef tweaks and suggestions
bvaughn added a commit that referenced this issue Mar 29, 2018
Merge createRef docs into 16.3 release blog
@kail-287 kail-287 mentioned this issue Dec 19, 2019
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

reactjs#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant