-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Languages" page #1691
Add "Languages" page #1691
Changes from all commits
c737cd4
d2d54b6
43a4477
88ea9c8
cba5894
14381e3
287521c
dfa0fc5
7c80589
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
# Status enums indicate what percentage of "core" content has been translated: | ||
# 0: Incomplete (0–49%) | ||
# 1: Partially complete (50–94%) | ||
# 2: Complete (95–100%) | ||
|
||
- name: English | ||
translated_name: English | ||
code: en | ||
status: 2 | ||
- name: Arabic | ||
translated_name: العربية | ||
code: ar | ||
status: 0 | ||
- name: Azerbaijani | ||
translated_name: Azərbaycanca | ||
code: az | ||
status: 0 | ||
- name: Bulgarian | ||
translated_name: Български | ||
code: bg | ||
status: 0 | ||
- name: Bengali | ||
translated_name: বাংলা | ||
code: bn | ||
status: 0 | ||
- name: German | ||
translated_name: Deutsch | ||
code: de | ||
status: 0 | ||
- name: Spanish | ||
translated_name: Español | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. English goes here! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could ask the translations to do it (add english and remove their language from the list) but that’s a lot of redundant effort |
||
code: es | ||
status: 2 | ||
- name: Persian | ||
translated_name: فارسی | ||
code: fa | ||
status: 0 | ||
- name: French | ||
translated_name: Français | ||
code: fr | ||
status: 0 | ||
- name: Hebrew | ||
translated_name: עברית | ||
code: he | ||
status: 0 | ||
- name: Hindi | ||
translated_name: हिन्दी | ||
code: hi | ||
status: 0 | ||
- name: Armenian | ||
translated_name: Հայերեն | ||
code: hy | ||
status: 0 | ||
- name: Indonesian | ||
translated_name: Bahasa Indonesia | ||
code: id | ||
status: 0 | ||
- name: Italian | ||
translated_name: Italiano | ||
code: it | ||
status: 0 | ||
- name: Japanese | ||
translated_name: 日本語 | ||
code: ja | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically Japanese and Brazillian Portuguese aren’t completely ready yet so I’d change these to false for now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the threshold? I don't think they need to be "completely ready". I guess we can bucket things into three groups:
The question is what should those thresholds be? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The “100%” is for a “core” subset of pages defined by Dan (home page, tutorial, basics, apis). For example, some of the Spanish hooks docs aren’t done yet but it”s still 100% since it finished the core. Japanese and Portuguese are at around 70% on those (Jp doesn’t have the tutorial yet). Plus, there are final tasks like checking for consistency of terminology that need to be done before marking as complete (which I’m going through with Spanish right now) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a little more information than I had before, but I think it's still a bit vague to me. Is this written down somewhere in a more objective format, that we can refer to if we need to know which bucket a given subdomain falls into? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I picked some somewhat arbitrary % thresholds for now (specified via inline comments). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gaearon what do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At first look, I think the proposed categories are maybe too fine grained. I don't think it's necessary (or all that helpful) to distinguish between released, complete, and complete+. I also don't really want to have to move sites around between those categories each time we make significant changes to core pages. Similarly, I'm not sure there's much value in distinguishing between "in-progress" and lesser translated states. I think it's worth showing all translations so that we direct potential contributors to them. I think it is important to indicate "this is not done yet" so we don't get people's hopes up for nothing– but I think the current 3 enums already do this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bvaughn It wouldn't be different sections for "complete"/"complete+" stuff and we don't have to add it in now. It's morel like... giving maintainers a gold star to encourage them to go beyond the core pages of translations. In that case I'd rather have just "released" and "in progress", without an arbitrary cut-off point. That might be the best option. But I also want @gaearon to weigh in. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like you two agree on the number of sections on the page but @tesseralis wants to add extra “distinguishing” marks to some translations? I’d say it’s fine to leave it out of the MVP and add a bit later. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fine by me. I added the extra steps to isreactreadyyet.com since it's easier to verify those :) |
||
status: 1 | ||
- name: Korean | ||
translated_name: 한국어 | ||
code: ko | ||
status: 0 | ||
- name: Malayalam | ||
translated_name: മലയാളം | ||
code: ml | ||
status: 0 | ||
- name: Nepali | ||
translated_name: नेपाली | ||
code: ne | ||
status: 0 | ||
- name: Dutch | ||
translated_name: Nederlands | ||
code: nl | ||
status: 0 | ||
- name: Polish | ||
translated_name: Polski | ||
code: pl | ||
status: 0 | ||
- name: Portuguese (Brazil) | ||
translated_name: Português do Brasil | ||
code: pt-br | ||
status: 1 | ||
- name: Portuguese (Portugal) | ||
translated_name: Português europeu | ||
code: pt-pt | ||
status: 0 | ||
- name: Romanian | ||
translated_name: Română | ||
code: ro | ||
status: 0 | ||
- name: Russian | ||
translated_name: Русский | ||
code: ru | ||
status: 0 | ||
- name: Sinhala | ||
translated_name: සිංහල | ||
code: si | ||
status: 0 | ||
- name: Tamil | ||
translated_name: தமிழ் | ||
code: ta | ||
status: 0 | ||
- name: Turkish | ||
translated_name: Türkçe | ||
code: tr | ||
status: 0 | ||
- name: Ukrainian | ||
translated_name: Українська | ||
code: uk | ||
status: 0 | ||
- name: Uzbek | ||
translated_name: Oʻzbekcha | ||
code: uz | ||
status: 0 | ||
- name: Vietnamese | ||
translated_name: Tiếng Việt | ||
code: vi | ||
status: 0 | ||
- name: Simplified Chinese | ||
translated_name: 简体中文 | ||
code: zh-hans | ||
status: 0 | ||
- name: Traditional Chinese | ||
translated_name: 繁體中文 | ||
code: zh-hant | ||
status: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we're using enums instead of strings (
incomplete
partial
complete
, etc.)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I think the meaning of string labels is ambiguous ("incomplete" and "partial" are synonymous). So I choose a numeric value that at least indicates progression (1 is more complete than 0, 2 is more complete than 1).