Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New blog post for translations #1721

Merged
merged 8 commits into from
Feb 23, 2019
Merged

New blog post for translations #1721

merged 8 commits into from
Feb 23, 2019

Conversation

tesseralis
Copy link
Member

Dependent on #1691

@sophiebits could you take a look at this and give feedback? (Dan said you would)

@reactjs-bot
Copy link

reactjs-bot commented Feb 21, 2019

Deploy preview for reactjs ready!

Built with commit 805b054

https://deploy-preview-1721--reactjs.netlify.com

Copy link
Member

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great post overall. Some comments inline.

content/blog/2019-02-20-react-translations.md Outdated Show resolved Hide resolved
content/blog/2019-02-20-react-translations.md Outdated Show resolved Hide resolved
content/blog/2019-02-20-react-translations.md Outdated Show resolved Hide resolved
content/blog/2019-02-20-react-translations.md Outdated Show resolved Hide resolved
content/blog/2019-02-20-react-translations.md Outdated Show resolved Hide resolved
@@ -0,0 +1,75 @@
---
title: "¡React en español! And Other Languages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we singling out Spanish? Both in this title and in the thanks at the end. It sounds like we have three languages available already and more soon right?

I guess from https://isreacttranslatedyet.com/ Spanish is the first to 100%? I might say "Special congrats to the Spanish translation team for being the first to hit 100% completion." or similar in the body of the post, but I worry about making the title seem too narrow – people might think it's just Spanish.

(Also, to my eyes this would look better with a lowercase "and".)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, they're the first to actually "finish" finish. I don't really know what's the best way to write it without implying the other two were not as good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophiebits Do you have ideas for alternative titles?

Copy link
Member

@sophiebits sophiebits Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe…

React: en español, 日本語で, em português!

/shrug

(also please get a japanese speaker to check that if you wanna go with that)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

React in español, portuguese do brazíl, 日本語, and more!

Copy link
Member Author

@tesseralis tesseralis Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another title idea:

Is React Translated Yet? ¡Sí! はい! Sim!

* Don't single out Spanish translation since it's already mentioned at the top
* Rename the post
@gaearon gaearon merged commit d156beb into master Feb 23, 2019
@rickhanlonii rickhanlonii deleted the translation-blog-post branch April 29, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants