Extracting Header and Footer Links from source into content #2270
Conversation
|
Deploy preview for reactjs ready! Built with commit 8c4800c |
There was a problem hiding this comment.
Just one nit about placement and naming.
@GasimGasimzada do you want to just have this PR be for the header/footer links and do the rest in another one so we can keep things simple?
GasimGasimzada
changed the title
- Remove them from section list - Add keys to nav array items when mapping
Okay, let’s keep things simple. I will rename this PR to reflect that it is only about Footer and Header links. |
|
@GasimGasimzada I think you still need the |
|
@tesseralis sorry. I thought it was fixed when you referenced the PR. I added them back for YAML files. Regarding looking at Flow typings, let's do one thing at a time because I have an idea on how to go further regarding extracting strings. However, I need to spend some time investigating the problem before I can come up with a solution. |
|
@tesseralis hello, if everything is okay here, could you please merge this; so that, I can move to extracting translatable strings? |
This PR started from conversation with @tesseralis about creating a Gatsby theme and using that theme in localization pages. However, there are some strings in source files that need to be translatable before getting into creating the Gatsby theme. So, in this PR is about extracting header and footer links.
Things To Do
So far, in this PR, I have extracted footer and header links into their respective YAML files and loaded them into appropriate components. However, there are some caveats (for example, I think it would make more sense if the Github link in Header and Footer are loaded from the same place.)