Skip to content

Fix redirects #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix redirects #3516

merged 1 commit into from
Feb 10, 2021

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Feb 10, 2021

Should fix #3138.

This method returns a Promise which wasn't awaited. I suspect this caused a race condition with another plugin to write to the same file, and the other plugin overwrote this one's result. Now they should write sequentially. (I hope.)

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 8a260b5

https://deploy-preview-3516--reactjs.netlify.app

@gaearon
Copy link
Member Author

gaearon commented Feb 10, 2021

that was it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation links missing on versions >=16.9
4 participants