Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: googleTranslate breaks sandboxes #3984

Merged
merged 1 commit into from
Oct 23, 2021
Merged

fix: googleTranslate breaks sandboxes #3984

merged 1 commit into from
Oct 23, 2021

Conversation

shrirambalaji
Copy link
Contributor

@shrirambalaji shrirambalaji commented Oct 23, 2021 •
edited
Loading

Fixes #3977 by disabling translation on sandbox source code and preview.

image

@rachelnabors rachelnabors merged commit 455d124 into reactjs:beta Oct 23, 2021
@rachelnabors
Copy link
Contributor

rachelnabors commented Oct 23, 2021 •
edited
Loading

2020_me_thanks

Thanks again for this!

@rachelnabors
Copy link
Contributor

Screenshot 2021-10-23 at 17 47 15

Just realized we have another one!

@shrirambalaji
Copy link
Contributor Author

shrirambalaji commented Oct 23, 2021 •
edited
Loading

Haha yeah, figured some Blocks might have been missed . Fix incoming 😁

@shrirambalaji shrirambalaji mentioned this pull request Oct 24, 2021
Merged
gaearon pushed a commit that referenced this pull request Oct 28, 2021
@shrirambalaji @gaearon
fix: googleTranslate breaks sandboxes (#3984)
04f42b0
gaearon pushed a commit that referenced this pull request Oct 28, 2021
@shrirambalaji @gaearon
fix: googleTranslate breaks sandboxes (#3984)
e056875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelnabors rachelnabors rachelnabors approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrirambalaji @rachelnabors @facebook-github-bot