Skip to content

Change "return statement" to "return keyword" #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Change "return statement" to "return keyword" #4137

merged 1 commit into from
Feb 7, 2022

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Dec 1, 2021 •
edited
Loading

If I understand correctly, a return statement would refer to everything between return and ; even if it spans multiple lines.

EDIT: And parentheses are not strictly necessary if you write the return statement like the following, so saying "you must wrap" may be too strong.

return <div>
  <img />
</div>;

@github-actions github-actions bot added the beta label Dec 1, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 91.32 KB (🟡 +156 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Hundred Eighty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 203.61 KB (🟡 +475 B) 294.94 KB
/404 202.72 KB (🟡 +485 B) 294.05 KB
/blog 37.28 KB (🟢 -643 B) 128.6 KB
/blog/2013/06/02/jsfiddle-integration 213.73 KB (🟢 -110 B) 305.06 KB
/blog/2013/06/05/why-react 215.46 KB (🟢 -115 B) 306.78 KB
/blog/2013/06/12/community-roundup 215.16 KB (🟢 -112 B) 306.49 KB
/blog/2013/06/19/community-roundup-2 215.83 KB (🟢 -113 B) 307.16 KB
/blog/2013/06/21/react-v0-3-3 213.88 KB (🟢 -112 B) 305.21 KB
/blog/2013/06/27/community-roundup-3 216.2 KB (🟢 -114 B) 307.52 KB
/blog/2013/07/02/react-v0-4-autobind-by-default 214.5 KB (🟢 -109 B) 305.82 KB
/blog/2013/07/03/community-roundup-4 215.57 KB (🟢 -113 B) 306.89 KB
/blog/2013/07/11/react-v0-4-prop-validation-and-default-values 214.37 KB (🟢 -112 B) 305.69 KB
/blog/2013/07/17/react-v0-4-0 215.08 KB (🟢 -111 B) 306.4 KB
/blog/2013/07/23/community-roundup-5 215.96 KB (🟢 -111 B) 307.29 KB
/blog/2013/07/26/react-v0-4-1 213.85 KB (🟢 -110 B) 305.17 KB
/blog/2013/07/30/use-react-and-jsx-in-ruby-on-rails 214.45 KB (🟢 -110 B) 305.77 KB
/blog/2013/08/05/community-roundup-6 215.25 KB (🟢 -114 B) 306.58 KB
/blog/2013/08/19/use-react-and-jsx-in-python-applications 214.46 KB (🟢 -111 B) 305.78 KB
/blog/2013/08/26/community-roundup-7 215.42 KB (🟢 -112 B) 306.75 KB
/blog/2013/09/24/community-roundup-8 216.86 KB (🟢 -113 B) 308.18 KB
/blog/2013/10/03/community-roundup-9 215.79 KB (🟢 -116 B) 307.12 KB
/blog/2013/10/16/react-v0.5.0 215.47 KB (🟢 -114 B) 306.8 KB
/blog/2013/10/29/react-v0-5-1 213.83 KB (🟢 -113 B) 305.16 KB
/blog/2013/11/06/community-roundup-10 217.45 KB (🟢 -115 B) 308.78 KB
/blog/2013/11/18/community-roundup-11 216.53 KB (🟢 -112 B) 307.86 KB
/blog/2013/12/18/react-v0.5.2-v0.4.2 214.3 KB (🟢 -112 B) 305.63 KB
/blog/2013/12/19/react-v0.8.0 214.73 KB (🟢 -110 B) 306.05 KB
/blog/2013/12/23/community-roundup-12 216.19 KB (🟢 -112 B) 307.51 KB
/blog/2013/12/30/community-roundup-13 215.97 KB (🟢 -114 B) 307.29 KB
/blog/2014/01/02/react-chrome-developer-tools 214.22 KB (🟢 -111 B) 305.55 KB
/blog/2014/01/06/community-roundup-14 215.56 KB (🟢 -111 B) 306.89 KB
/blog/2014/02/05/community-roundup-15 216.78 KB (🟢 -110 B) 308.1 KB
/blog/2014/02/15/community-roundup-16 216.49 KB (🟢 -114 B) 307.82 KB
/blog/2014/02/16/react-v0.9-rc1 216.9 KB (🟢 -113 B) 308.22 KB
/blog/2014/02/20/react-v0.9 217.34 KB (🟢 -116 B) 308.67 KB
/blog/2014/02/24/community-roundup-17 216.2 KB (🟢 -115 B) 307.53 KB
/blog/2014/03/14/community-roundup-18 217.17 KB (🟢 -110 B) 308.5 KB
/blog/2014/03/19/react-v0.10-rc1 215.48 KB (🟢 -114 B) 306.8 KB
/blog/2014/03/21/react-v0.10 215.5 KB (🟢 -113 B) 306.83 KB
/blog/2014/03/28/the-road-to-1.0 215.61 KB (🟢 -114 B) 306.94 KB
/blog/2014/04/04/reactnet 214.26 KB (🟢 -113 B) 305.58 KB
/blog/2014/05/06/flux 214.38 KB (🟢 -109 B) 305.71 KB
/blog/2014/05/29/one-year-of-open-source-react 214.61 KB (🟢 -110 B) 305.93 KB
/blog/2014/06/27/community-roundup-19 216.15 KB (🟢 -117 B) 307.47 KB
/blog/2014/07/13/react-v0.11-rc1 216.54 KB (🟢 -112 B) 307.86 KB
/blog/2014/07/17/react-v0.11 217.79 KB (🟢 -115 B) 309.12 KB
/blog/2014/07/25/react-v0.11.1 214.74 KB (🟢 -112 B) 306.07 KB
/blog/2014/07/28/community-roundup-20 216.29 KB (🟢 -114 B) 307.62 KB
/blog/2014/07/30/flux-actions-and-the-dispatcher 215.93 KB (🟢 -111 B) 307.25 KB
/blog/2014/08/03/community-roundup-21 215.96 KB (🟢 -114 B) 307.29 KB
/blog/2014/09/03/introducing-the-jsx-specification 213.97 KB (🟢 -110 B) 305.29 KB
/blog/2014/09/12/community-round-up-22 216.44 KB (🟢 -110 B) 307.77 KB
/blog/2014/09/16/react-v0.11.2 214.74 KB (🟢 -111 B) 306.06 KB
/blog/2014/09/24/testing-flux-applications 217.92 KB (🟢 -114 B) 309.24 KB
/blog/2014/10/14/introducing-react-elements 216.87 KB (🟢 -114 B) 308.2 KB
/blog/2014/10/16/react-v0.12-rc1 216.84 KB (🟢 -115 B) 308.16 KB
/blog/2014/10/17/community-roundup-23 217.41 KB (🟢 -112 B) 308.73 KB
/blog/2014/10/27/react-js-conf 214.01 KB (🟢 -111 B) 305.34 KB
/blog/2014/10/28/react-v0.12 216.78 KB (🟢 -108 B) 308.11 KB
/blog/2014/11/24/react-js-conf-updates 214.4 KB (🟢 -110 B) 305.72 KB
/blog/2014/11/25/community-roundup-24 217.64 KB (🟢 -117 B) 308.96 KB
/blog/2014/12/18/react-v0.12.2 214.43 KB (🟢 -110 B) 305.75 KB
/blog/2014/12/19/react-js-conf-diversity-scholarship 214.82 KB (🟢 -111 B) 306.14 KB
/blog/2015/01/27/react-v0.13.0-beta-1 215.79 KB (🟢 -116 B) 307.11 KB
/blog/2015/02/18/react-conf-roundup-2015 217.77 KB (🟢 -112 B) 309.1 KB
/blog/2015/02/20/introducing-relay-and-graphql 216.92 KB (🟢 -111 B) 308.25 KB
/blog/2015/02/24/react-v0.13-rc1 215.83 KB (🟢 -114 B) 307.15 KB
/blog/2015/02/24/streamlining-react-elements 218.38 KB (🟢 -117 B) 309.7 KB
/blog/2015/03/03/react-v0.13-rc2 215.16 KB (🟢 -113 B) 306.49 KB
/blog/2015/03/04/community-roundup-25 216.13 KB (🟢 -115 B) 307.45 KB
/blog/2015/03/10/react-v0.13 216.44 KB (🟢 -113 B) 307.77 KB
/blog/2015/03/16/react-v0.13.1 214.26 KB (🟢 -110 B) 305.59 KB
/blog/2015/03/19/building-the-facebook-news-feed-with-relay 217.02 KB (🟢 -112 B) 308.34 KB
/blog/2015/03/26/introducing-react-native 214.16 KB (🟢 -112 B) 305.48 KB
/blog/2015/03/30/community-roundup-26 216.09 KB (🟢 -116 B) 307.41 KB
/blog/2015/04/17/react-native-v0.4 215 KB (🟢 -111 B) 306.33 KB
/blog/2015/04/18/react-v0.13.2 214.34 KB (🟢 -113 B) 305.66 KB
/blog/2015/05/01/graphql-introduction 218.83 KB (🟢 -113 B) 310.15 KB
/blog/2015/05/08/react-v0.13.3 214.23 KB (🟢 -109 B) 305.55 KB
/blog/2015/05/22/react-native-release-process 214.38 KB (🟢 -111 B) 305.7 KB
/blog/2015/06/12/deprecating-jstransform-and-react-tools 214.83 KB (🟢 -112 B) 306.16 KB
/blog/2015/07/03/react-v0.14-beta-1 216.34 KB (🟢 -113 B) 307.67 KB
/blog/2015/08/03/new-react-devtools-beta 214.94 KB (🟢 -114 B) 306.27 KB
/blog/2015/08/11/relay-technical-preview 215.01 KB (🟢 -110 B) 306.33 KB
/blog/2015/08/13/reacteurope-roundup 216.6 KB (🟢 -111 B) 307.92 KB
/blog/2015/09/02/new-react-developer-tools 214.36 KB (🟢 -111 B) 305.69 KB
/blog/2015/09/10/react-v0.14-rc1 220 KB (🟢 -165 B) 311.32 KB
/blog/2015/09/14/community-roundup-27 216.52 KB (🟢 -113 B) 307.84 KB
/blog/2015/10/01/react-render-and-top-level-api 215.49 KB (🟢 -112 B) 306.81 KB
/blog/2015/10/07/react-v0.14 220.48 KB (🟢 -171 B) 311.8 KB
/blog/2015/10/19/reactiflux-is-moving-to-discord 216.24 KB (🟢 -109 B) 307.57 KB
/blog/2015/10/28/react-v0.14.1 214.25 KB (🟢 -111 B) 305.58 KB
/blog/2015/11/02/react-v0.14.2 214.28 KB (🟢 -111 B) 305.61 KB
/blog/2015/11/18/react-v0.14.3 214.41 KB (🟢 -110 B) 305.73 KB
/blog/2015/12/04/react-js-conf-2016-diversity-scholarship 215.28 KB (🟢 -109 B) 306.6 KB
/blog/2015/12/16/ismounted-antipattern 214.88 KB (🟢 -110 B) 306.2 KB
/blog/2015/12/18/react-components-elements-and-instances 218.8 KB (🟢 -113 B) 310.13 KB
/blog/2015/12/29/react-v0.14.4 214.07 KB (🟢 -112 B) 305.4 KB
/blog/2016/01/08/A-implies-B-does-not-imply-B-implies-A 215.09 KB (🟢 -112 B) 306.42 KB
/blog/2016/01/12/discontinuing-ie8-support 213.9 KB (🟢 -111 B) 305.22 KB
/blog/2016/02/19/new-versioning-scheme 215.28 KB (🟢 -112 B) 306.6 KB
/blog/2016/03/07/react-v15-rc1 217.97 KB (🟢 -173 B) 309.3 KB
/blog/2016/03/16/react-v15-rc2 214.89 KB (🟢 -112 B) 306.22 KB
/blog/2016/03/29/react-v0.14.8 214.03 KB (🟢 -112 B) 305.35 KB
/blog/2016/04/07/react-v15 222.09 KB (🟢 -252 B) 313.42 KB
/blog/2016/04/08/react-v15.0.1 214.78 KB (🟢 -110 B) 306.11 KB
/blog/2016/07/11/introducing-reacts-error-code-system 214.5 KB (🟢 -111 B) 305.82 KB
/blog/2016/07/13/mixins-considered-harmful 222.65 KB (🟢 -116 B) 313.98 KB
/blog/2016/07/22/create-apps-with-no-configuration 217.98 KB (🟢 -118 B) 309.3 KB
/blog/2016/08/05/relay-state-of-the-state 218.02 KB (🟢 -114 B) 309.34 KB
/blog/2016/09/28/our-first-50000-stars 219.47 KB (🟢 -115 B) 310.79 KB
/blog/2016/11/16/react-v15.4.0 217.42 KB (🟢 -116 B) 308.74 KB
/blog/2017/04/07/react-v15.5.0 217.98 KB (🟢 -116 B) 309.3 KB
/blog/2017/05/18/whats-new-in-create-react-app 217.38 KB (🟢 -124 B) 308.7 KB
/blog/2017/06/13/react-v15.6.0 216 KB (🟢 -113 B) 307.33 KB
/blog/2017/07/26/error-handling-in-react-16 216.35 KB (🟢 -113 B) 307.67 KB
/blog/2017/09/08/dom-attributes-in-react-16 216.78 KB (🟢 -116 B) 308.11 KB
/blog/2017/09/25/react-v15.6.2 215.12 KB (🟢 -114 B) 306.44 KB
/blog/2017/09/26/react-v16.0 220.25 KB (🟢 -115 B) 311.57 KB
/blog/2017/11/28/react-v16.2.0-fragment-support 218.16 KB (🟢 -120 B) 309.48 KB
/blog/2017/12/07/introducing-the-react-rfc-process 214.7 KB (🟢 -111 B) 306.02 KB
/blog/2017/12/15/improving-the-repository-infrastructure 230.49 KB (🟢 -122 B) 321.81 KB
/blog/2018/03/01/sneak-peek-beyond-react-16 214.65 KB (🟢 -111 B) 305.98 KB
/blog/2018/03/27/update-on-async-rendering 219.9 KB (🟢 -114 B) 311.22 KB
/blog/2018/03/29/react-v-16-3 216.72 KB (🟢 -108 B) 308.04 KB
/blog/2018/05/23/react-v-16-4 216.86 KB (🟢 -112 B) 308.18 KB
/blog/2018/06/07/you-probably-dont-need-derived-state 220.52 KB (🟢 -115 B) 311.84 KB
/blog/2018/08/01/react-v-16-4-2 215.51 KB (🟢 -116 B) 306.83 KB
/blog/2018/09/10/introducing-the-react-profiler 217.11 KB (🟢 -121 B) 308.44 KB
/blog/2018/10/01/create-react-app-v2 217.59 KB (🟢 -111 B) 308.92 KB
/blog/2018/10/23/react-v-16-6 216.79 KB (🟢 -112 B) 308.12 KB
/blog/2018/11/13/react-conf-recap 214.51 KB (🟢 -112 B) 305.83 KB
/blog/2018/11/27/react-16-roadmap 220.7 KB (🟢 -117 B) 312.02 KB
/blog/2018/12/19/react-v-16-7 215.63 KB (🟢 -112 B) 306.95 KB
/blog/2019/02/06/react-v16.8.0 217.89 KB (🟢 -113 B) 309.22 KB
/blog/2019/02/23/is-react-translated-yet 217.46 KB (🟢 -114 B) 308.79 KB
/blog/2019/08/08/react-v16.9.0 220.39 KB (🟢 -117 B) 311.72 KB
/blog/2019/08/15/new-react-devtools 215 KB (🟢 -114 B) 306.32 KB
/blog/2019/10/22/react-release-channels 216.81 KB (🟢 -112 B) 308.13 KB
/blog/2019/11/06/building-great-user-experiences-with-concurrent-mode-and-suspense 221.51 KB (🟢 -108 B) 312.84 KB
/blog/2020/02/26/react-v16.13.0 217.74 KB (🟢 -115 B) 309.06 KB
/blog/2020/08/10/react-v17-rc 224.02 KB (🟢 -117 B) 315.34 KB
/blog/all 53.4 KB (🟢 -631 B) 144.72 KB
/community 203.31 KB (🟡 +475 B) 294.63 KB
/community/acknowledgements 204.5 KB (🟡 +475 B) 295.82 KB
/community/meet-the-team 205.02 KB (🟡 +474 B) 296.35 KB
/learn 212.02 KB (🟡 +486 B) 303.34 KB
/learn/add-react-to-a-website 208.13 KB (🟡 +481 B) 299.46 KB
/learn/adding-interactivity 209.93 KB (🟡 +483 B) 301.26 KB
/learn/choosing-the-state-structure 215.68 KB (🟡 +481 B) 307 KB
/learn/conditional-rendering 207.91 KB (🟡 +486 B) 299.23 KB
/learn/describing-the-ui 207.12 KB (🟡 +483 B) 298.44 KB
/learn/editor-setup 204.4 KB (🟡 +483 B) 295.72 KB
/learn/escape-hatches 202.63 KB (🟡 +481 B) 293.96 KB
/learn/extracting-state-logic-into-a-reducer 213.28 KB (🟡 +484 B) 304.6 KB
/learn/importing-and-exporting-components 206.31 KB (🟡 +482 B) 297.63 KB
/learn/installation 203.95 KB (🟡 +481 B) 295.28 KB
/learn/javascript-in-jsx-with-curly-braces 206.38 KB (🟡 +483 B) 297.71 KB
/learn/keeping-components-pure 210.52 KB (🟡 +483 B) 301.84 KB
/learn/managing-state 209.23 KB (🟡 +484 B) 300.56 KB
/learn/manipulating-the-dom-with-refs 211.15 KB (🟡 +482 B) 302.47 KB
/learn/passing-data-deeply-with-context 210.66 KB (🟡 +483 B) 301.99 KB
/learn/passing-props-to-a-component 210.08 KB (🟡 +483 B) 301.41 KB
/learn/preserving-and-resetting-state 212.9 KB (🟡 +482 B) 304.22 KB
/learn/queueing-a-series-of-state-updates 207.88 KB (🟡 +482 B) 299.2 KB
/learn/react-developer-tools 203.83 KB (🟡 +481 B) 295.16 KB
/learn/reacting-to-input-with-state 212.36 KB (🟡 +491 B) 303.68 KB
/learn/referencing-values-with-refs 209.39 KB (🟡 +479 B) 300.72 KB
/learn/render-and-commit 206.37 KB (🟡 +483 B) 297.69 KB
/learn/rendering-lists 210.43 KB (🟡 +481 B) 301.76 KB
/learn/responding-to-events 209.43 KB (🟡 +481 B) 300.76 KB
/learn/scaling-up-with-reducer-and-context 207.46 KB (🟡 +483 B) 298.78 KB
/learn/sharing-state-between-components 208.16 KB (🟡 +482 B) 299.49 KB
/learn/start-a-new-react-project 204.81 KB (🟡 +482 B) 296.13 KB
/learn/state-a-components-memory 213.6 KB (🟡 +481 B) 304.93 KB
/learn/state-as-a-snapshot 207.42 KB (🟡 +483 B) 298.75 KB
/learn/thinking-in-react 209.31 KB (🟡 +481 B) 300.64 KB
/learn/updating-arrays-in-state 211.5 KB (🟡 +479 B) 302.82 KB
/learn/updating-objects-in-state 211.21 KB (🟡 +482 B) 302.54 KB
/learn/writing-markup-with-jsx 206.31 KB (🟡 +483 B) 297.63 KB
/learn/your-first-component 207.22 KB (🟡 +492 B) 298.54 KB
/reference 203.26 KB (🟡 +469 B) 294.58 KB
/reference/reactdom 203.41 KB (🟡 +475 B) 294.73 KB
/reference/render 204.75 KB (🟡 +476 B) 296.08 KB
/reference/usestate 211.23 KB (🟡 +476 B) 302.56 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@gaearon gaearon merged commit 4be33b8 into reactjs:main Feb 7, 2022
@smikitky smikitky deleted the patch-1 branch February 9, 2022 00:08
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
@docschina-bot @shamwela
@gaearon @stuymedova @smikitky @aayush-k @KnowsCount
docs(en): merge reactjs.org/main into zh-hans.reactjs.org/main @ cfa3670
eccde34 
 (reactjs#721)

* Sandpack error icon overlapping issue fix (reactjs#4302)

* sandpack error icon overlapping issue fix

* modified errorline css

* Improve font display (reactjs#4308)

* Generate Ids when there are none in local development (reactjs#4304)

* Generate Ids when there are no headings

* Tweak code

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

* [Beta] useState Troubleshooting (reactjs#4309)

* [Beta] useState Troubleshooting

* Tweaks

* tweak

* docs: phrasing a sentence (reactjs#4185)

* docs: phrasing a sentence (reactjs#4182)

* docs: phrasing a sentence

* Update extracting-state-logic-into-a-reducer.md

Co-authored-by: dan <dan.abramov@gmail.com>

* docs: fix a grammatical error (reactjs#4183)

Co-authored-by: dan <dan.abramov@gmail.com>

* Change "return statement" to "return keyword" (reactjs#4137)

* small fixes to stopwatch codesandbox (reactjs#4110)

* small fixes to stopwatch codesandbox

noticed that the explanation for the first stopwatch codesandbox mentions "update the time every 10 milliseconds" so updated the codesandbox to reflect that

also there's a small nuanced bug in the second stopwatch codesandbox where each call to `handleStart()` sets a new interval without checking if there's already one ongoing. 

Ie: If the user accidentally double clicks the start button, they set two intervals for updating `now` every 10ms and then intervalRef only retains the second interval ID. Thus, it's impossible to actually stop the timer because `handleStop()` will only clear the latest set interval while the original one will keep executing.

* Update referencing-values-with-refs.md

* Update referencing-values-with-refs.md

* Update referencing-values-with-refs.md

Co-authored-by: dan <dan.abramov@gmail.com>

* Resolve conflicts

Co-authored-by: Amaresh  S M <amaresh.suriya@freshworks.com>
Co-authored-by: Sha Mwe La <62544170+shamwela@users.noreply.github.com>
Co-authored-by: Strek <harish.sethuraman@freshworks.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Co-authored-by: Sofya Tuymedova <stuymedova@gmail.com>
Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp>
Co-authored-by: Aayush Kumar <aayush.kumarmail@gmail.com>
Co-authored-by: KnowsCount <knowscount@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejcheng ejcheng ejcheng approved these changes

Assignees
No one assigned
Labels
beta CLA Signed type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smikitky @ejcheng @gaearon @facebook-github-bot @harish-sethuraman