Skip to content

fix(gh-workflow): skip comment when push directly #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix(gh-workflow): skip comment when push directly #5860

wants to merge 4 commits into from

Conversation

awxiaoxian2020
Copy link
Contributor

closes #5801

@github-actions
Copy link

github-actions bot commented Apr 2, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@awxiaoxian2020
Copy link
Contributor Author

Hi, @gaearon it seems that github.event.workflow_run.event doesn't work. I use a stupid workaround but it works in zh-hans repo.

@awxiaoxian2020 awxiaoxian2020 deleted the fix branch April 29, 2023 07:32
@gaearon
Copy link
Member

gaearon commented Apr 29, 2023

what was the workaround? sorry i haven’t looked at this yet

@awxiaoxian2020
Copy link
Contributor Author

awxiaoxian2020 commented Apr 29, 2023 •
edited
Loading

Oh, @gaearon you update the comment workflow and I need to look into it to create a new Pull Request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GH workflow] update analyze.yml to avoid noisy notification
3 participants
@awxiaoxian2020 @gaearon @facebook-github-bot