Add guiding note #6501
Add guiding note #6501
Conversation
|
Hi @smith558! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thanks, but I'm not sure this adds much. |
Without that, this tutorial step is just assumed. It might seem obvious to you, but it took a fair time to realise when I went through the tutorial myself the first time. It broke all further examples that follow in the tutorial. This goes against being a beginner-friendly and guided tutorial. Additionally, look at my comment about misleading instructions that follow #6501 (comment). |
|
Re-opening, if you can make the change suggested above then we can merge! |
Sure! Happy to have it ready tomorrow (soon midnight here). |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Without the note, an entire tutorial step is just assumed. It might seem obvious to many, but it took a fair time to realise when I went through the tutorial myself the first time. It broke all further examples that follow in the tutorial. This goes against being a beginner-friendly and guided tutorial. Additionally, look at my comment about misleading instructions that follow if the guiding note is not there #6501 (comment).