Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex lookback crashing older browsers #6571

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

rickhanlonii
Copy link
Member

Fixes #6556

cc @SukkaW

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.1 KB (-4 B) 182.96 KB
/500 79.09 KB (-4 B) 182.96 KB
/[[...markdownPath]] 80.69 KB (-4 B) 184.55 KB
/errors 79.28 KB (-4 B) 183.14 KB
/errors/[errorCode] 79.25 KB (-4 B) 183.12 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@rickhanlonii rickhanlonii merged commit 4886261 into reactjs:main Jan 22, 2024
4 checks passed
@rickhanlonii rickhanlonii deleted the rh/fix-safari branch January 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application error: a client-side exception has occurred on official React.dev site
2 participants