Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbar of SidebarNav to make it tappable #6586

Merged

Conversation

tamonmon0417
Copy link
Contributor

@tamonmon0417 tamonmon0417 commented Jan 28, 2024

Fixes #3171
Fixes #5727
Fixes #6469

  • fixed scrollbar of SidebarNav to make it tappable by assigning z-10
  • it was under the main content layer so that you could not drag it
Screen.2024-01-28.20.42.35.mov

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Jan 28, 2024 0:00am

@facebook-github-bot
Copy link
Collaborator

Hi @tamonmon0417!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.1 KB (🟡 +5 B) 182.97 KB
/500 79.1 KB (🟡 +5 B) 182.96 KB
/[[...markdownPath]] 80.7 KB (🟡 +5 B) 184.56 KB
/errors 79.28 KB (🟡 +5 B) 183.15 KB
/errors/[errorCode] 79.26 KB (🟡 +5 B) 183.13 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@pwbriggs
Copy link

pwbriggs commented Jan 28, 2024

Hello @tamonmon0417, thanks for the PR! ❤️

Similar issues and PRs have already been opened. Can you please explain why your fix is different/better than #5750, #5898, #6244, #6329, #6479, and #6485?

Thanks! 😄

@tamonmon0417
Copy link
Contributor Author

Hi @pwbriggs , thank you for your comment!

The best thing about this commit is to keep the current layout.
It just corrects the layer order to the ideal one.
Any suggestion is welcome!

ref. #5750 (review)

@tamonmon0417
Copy link
Contributor Author

Hi @pwbriggs, do you know who I should ask to review?

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixes the issue without changing layout. If there are other issues we can fix forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants