Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Conf banner #6595

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

mattcarrollcode
Copy link
Contributor

@mattcarrollcode mattcarrollcode commented Feb 1, 2024

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 1, 2024 4:16am

Copy link

github-actions bot commented Feb 1, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.05 KB (🟢 -54 B) 182.91 KB
/500 79.04 KB (🟢 -54 B) 182.91 KB
/[[...markdownPath]] 80.64 KB (🟢 -54 B) 184.5 KB
/errors 79.23 KB (🟢 -54 B) 183.09 KB
/errors/[errorCode] 79.2 KB (🟢 -54 B) 183.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@cpojer
Copy link
Member

cpojer commented Feb 1, 2024

I don't think shipping one banner with info about React Conf and support for Ukraine at the same time makes sense. It looks extremely odd (please don't ship two banners either).

@mattcarrollcode mattcarrollcode merged commit 9a843b6 into reactjs:main Feb 8, 2024
4 checks passed
@cpojer
Copy link
Member

cpojer commented Feb 11, 2024

@mattcarrollcode The solution you ended up with looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants