Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sandpack): clear up bundler timeout when there's a syntax error #6659

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

danilowoz
Copy link
Contributor

Update @codesandbox/sandpack-react version to 2.13.1, which fixes an issue when the bundler responds with a syntax error and the Sandpack instance didn't use to clear the bundler timeout (codesandbox/sandpack#1087)

Close #6644

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 24, 2024 11:38am

Copy link

github-actions bot commented Feb 23, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.87 KB (🟡 +17 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@danilowoz danilowoz marked this pull request as draft February 23, 2024 20:12
@danilowoz
Copy link
Contributor Author

Not fixed yet, it must be something else on the Sandpack integration

@rickhanlonii
Copy link
Member

Damn, nice attempt tho

@danilowoz
Copy link
Contributor Author

Okay, I figured it out! The React.dev uses a pinned Sandpack bundler URL, which makes it more stable and predictable, but on the other hand, it doesn't include any latest fix. 2 months ago, we shipped an important fix on the Sandpack bundler (codesandbox/sandpack-bundler#62), and we didn't update it here.

So, it should be fixed now, and I'll make sure to always update the URL here in case we publish any important fix.

@danilowoz danilowoz marked this pull request as ready for review February 24, 2024 11:41
@harish-sethuraman
Copy link
Collaborator

weird but the output didn't work on some attempts but worked when reloaded
Screenshot 2024-02-24 at 6 35 25 PM

@danilowoz
Copy link
Contributor Author

That's weird, could you please describe how to reproduce it and which page that happens?

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find, thanks for jumping on this so quick

@rickhanlonii rickhanlonii merged commit 081d100 into reactjs:main Feb 24, 2024
4 checks passed
@danilowoz danilowoz deleted the fix/sandpack-timeout branch February 24, 2024 16:23
@bondz
Copy link
Contributor

bondz commented Feb 26, 2024

@danilowoz see #6662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Challenges section not connecting to sandbox
5 participants