-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sandpack): clear up bundler timeout when there's a syntax error #6659
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
103.87 KB (🟡 +17 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Not fixed yet, it must be something else on the Sandpack integration |
Damn, nice attempt tho |
Okay, I figured it out! The React.dev uses a pinned Sandpack bundler URL, which makes it more stable and predictable, but on the other hand, it doesn't include any latest fix. 2 months ago, we shipped an important fix on the Sandpack bundler (codesandbox/sandpack-bundler#62), and we didn't update it here. So, it should be fixed now, and I'll make sure to always update the URL here in case we publish any important fix. |
That's weird, could you please describe how to reproduce it and which page that happens? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome find, thanks for jumping on this so quick
@danilowoz see #6662 |
Update @codesandbox/sandpack-react version to 2.13.1, which fixes an issue when the bundler responds with a syntax error and the Sandpack instance didn't use to clear the bundler timeout (codesandbox/sandpack#1087)
Close #6644