Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version in engines into package.json file (^21.0.0) #6728

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

foridpathan
Copy link
Contributor

@foridpathan foridpathan commented Mar 31, 2024

Summary

This pull request updates the package.json file to extend the supported Node.js versions to include version 21.0.0. The engines field is now modified to:

"engines": { "node": "^16.8.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0" },

Problem I found

My current node version 21.6.1 so when I try to install dependencies and I get an incompatible error.
node

Error

error

Changes

  • The engines.node field in package.json has been updated to include ^21.0.0 alongside the previously supported versions. This change clarifies to developers and deployment environments which versions of Node.js are officially supported by our project.

Signed-off-by: Faridul Islam <foridpathan45@gmail.com>
Copy link

vercel bot commented Mar 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Mar 31, 2024 0:51am

@facebook-github-bot
Copy link
Collaborator

Hi @foridpathan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Tested locally and confirmed yarn && yarn debv works 👍

@rickhanlonii rickhanlonii merged commit 9748943 into reactjs:main Mar 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants