Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] remove unused ref in ExpandableCallout.tsx #6755

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kassens
Copy link
Collaborator

@kassens kassens commented Apr 15, 2024

Note that this component is not actually expandable and the ref got likely unused when that was removed

Note that this component is not actually expandable and the ref got likely unused when that was removed
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:59pm

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.87 KB (-6 B) 183.78 KB
/500 79.87 KB (-6 B) 183.77 KB
/[[...markdownPath]] 81.65 KB (-6 B) 185.55 KB
/errors 80.05 KB (-6 B) 183.96 KB
/errors/[errorCode] 80.03 KB (-6 B) 183.93 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@kassens kassens merged commit 56ca8f1 into reactjs:main Apr 15, 2024
4 checks passed
@kassens kassens deleted the unused-ref branch April 15, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants