Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:#7158 rss.js issue #7159

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix:#7158 rss.js issue #7159

merged 1 commit into from
Sep 30, 2024

Conversation

imparth7
Copy link
Contributor

The problem is getting the basename from the file path in the rss.js file.

Code before my changes

const id = filePath.split('/').slice(-1).join('');

Code after my changes

const id = path.basename(filePath);

issue: #7158

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:43pm
react-dev ✅ Ready (Inspect) Visit Preview Sep 11, 2024 4:43pm

@imparth7 imparth7 marked this pull request as draft September 24, 2024 13:45
@imparth7 imparth7 closed this Sep 24, 2024
@imparth7 imparth7 reopened this Sep 24, 2024
@imparth7 imparth7 marked this pull request as ready for review September 24, 2024 13:46
@github-actions GitHub Actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@imparth7 imparth7 mentioned this pull request Sep 27, 2024
Closed
rickhanlonii
rickhanlonii approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tested locally and works great

@rickhanlonii rickhanlonii merged commit d418485 into reactjs:main Sep 30, 2024
7 of 8 checks passed
This was referenced Sep 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imparth7 @rickhanlonii @facebook-github-bot