Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search results ranking and grouping #7183

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Sep 23, 2024

Overview

Shout out @markerikson for flagging the search issue and @shortcuts for the help fixing it!

Makes a few improvements to searching, some of which are applied to the search index already outside of this PR:

  • Fixes ranking so that React APIs and Learn are ranked at the top again. I think this regressed at some point. The fix was to move the pageRank attribute above exact in the sorting and ranking settings.
  • Split up the "React APIs" into different groups:
    • React APIs
    • React DOM APIs
    • React Server Components
    • Rules of React
    • Legacy React APIs (downranked)

The changes included here are:

  • Display the groups again (previously it was just a flat list with no grouping headings like React APIs)
  • Display more results (previously there were a very small number of results)

To do that I updated DocSearch depts, and added/updated the searchParameters.

Before

Screenshot 2024-09-23 at 3 35 08 PM

After

Screenshot 2024-09-23 at 3 32 01 PM

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:44pm
react-dev ✅ Ready (Inspect) Visit Preview Sep 23, 2024 7:44pm

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.3 KB (🟡 +112 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.33 KB (🟡 +67 B) 208.64 KB
/500 104.33 KB (🟡 +67 B) 208.63 KB
/[[...markdownPath]] 106.18 KB (🟡 +67 B) 210.48 KB
/errors 104.54 KB (🟡 +67 B) 208.85 KB
/errors/[errorCode] 104.52 KB (🟡 +67 B) 208.83 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@markerikson
Copy link
Contributor

Looks great!

@rickhanlonii rickhanlonii merged commit e2f089d into reactjs:main Sep 23, 2024
6 checks passed
@rickhanlonii rickhanlonii deleted the rh/search-results branch September 23, 2024 19:51
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have been accidentally added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh snap fixed here #7184

Copy link

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect! the bug is being fixed on our side too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants