Skip to content

fix: correct broken WAI-ARIA modal dialog link in createPortal reference #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

dimatitov
Copy link
Contributor

While translating the createPortal reference page to Russian, I tested the external WAI-ARIA link and noticed it led to the general APG homepage (#dialog_modal anchor is missing or invalid). I’ve replaced it with the correct and direct link to the Modal Dialog pattern page: https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal

This ensures users can access the specific modal accessibility guidelines without confusion.

@facebook-github-bot
Copy link
Collaborator

Hi @dimatitov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks

@rickhanlonii rickhanlonii merged commit 9db23d6 into reactjs:main Jun 2, 2025
6 checks passed
@dimatitov dimatitov deleted the create-portal-fix-ARIA branch June 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants