-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add more information about event and property binding on custom elements #7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
eps1lon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can we convert these snippets into sandboxes? Especially the event-handling part would be interesting to see in action.
|
@eps1lon I was thinking the same thing. EDIT: I figured out the |
|
Code samples have been moved to Sandpack |
eps1lon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thank you!
If you think it's helpful. These sort of docs tend to get stale pretty quickly and I thought the Component was straight forward enough to be figured out by looking at existing usage. |
This PR aims to document the behavior around React 19 and Custom Elements more accurately. Namely, the previous docs had outdated information regarding property passing.
In the new docs, we cover:
Questions
Some open-ended questions that I'd love feedback on from a reviewer:
Should we mention SSR behavior of Custom Elements? If so, what are they? The public proposal document outlines a few paths that may have been taken, but does not clarify which ones were taken in the end.
Should we mention other versions of React and when this support was introduced?
Should this be a dedicated reference page?
Preview of some of the docs