Skip to content

Translation FAQ: Passing Functions to Components #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 22, 2019
Merged

Translation FAQ: Passing Functions to Components #108

merged 7 commits into from
Feb 22, 2019

Conversation

marichka-offen
Copy link
Contributor

@marichka-offen marichka-offen commented Feb 12, 2019

Перезалито с PR #95

@marichka-offen marichka-offen changed the title Translation FAQ functions components Translation FAQ: Passing Functions to Components Feb 12, 2019
marichka-offen and others added 2 commits February 12, 2019 17:53
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил ещё предложения, можете прямо из гитхаба их прнять, никогда так не делал, но должно работать.

Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
@tesseralis tesseralis mentioned this pull request Feb 12, 2019
88 tasks
@lex111
Copy link
Member

lex111 commented Feb 12, 2019

Ещё заметил, что не везде используется буква "ё", можно воспользоваться пакетом, который автоматически проставит её (второй пункт)

@another-guy another-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 12, 2019
@lex111 lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 14, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне всё нравится 👍

@gcor
Copy link
Collaborator

gcor commented Feb 16, 2019

Отрисовка → рендер

Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пожалуйста, исправьте несколько помарок. ✏️

Спасибо огромное за работу над переводом! 🎉

@another-guy another-guy removed their assignment Feb 20, 2019
@lex111
Copy link
Member

lex111 commented Feb 21, 2019

@marichka-offen можете, пожалуйста, рассмотреть предложенные правки и принять их? Если по каким-либо причинам не можете, то это сделаем мы.

@another-guy another-guy self-assigned this Feb 21, 2019
Co-Authored-By: marichka-offen <40467112+marichka-offen@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for ru-reactjs ready!

Built with commit bf36c02

https://deploy-preview-108--ru-reactjs.netlify.com

1 similar comment
@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for ru-reactjs ready!

Built with commit bf36c02

https://deploy-preview-108--ru-reactjs.netlify.com

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
@another-guy
Copy link
Collaborator

@marichka-offen 💯 ! 🥇

@another-guy another-guy merged commit 54ea4e6 into reactjs:master Feb 22, 2019
@another-guy another-guy removed their assignment Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants