Skip to content

Translate "Invalid Hook Call Warning" #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 20, 2019
Merged

Translate "Invalid Hook Call Warning" #145

merged 7 commits into from
Feb 20, 2019

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Feb 15, 2019

No description provided.

@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 15, 2019
@lex111 lex111 requested a review from another-guy February 15, 2019 03:26
@tesseralis tesseralis mentioned this pull request Feb 15, 2019
Closed
88 tasks
angryermine
angryermine reviewed Feb 15, 2019
View reviewed changes
angryermine and others added 3 commits February 15, 2019 12:11
@angryermine @lex111
Update content/warnings/invalid-hook-call-warning.md
7e8f6d7 
Co-Authored-By: lex111 <lex61rus@gmail.com>
@angryermine @lex111
Update content/warnings/invalid-hook-call-warning.md
573c09f 
Co-Authored-By: lex111 <lex61rus@gmail.com>
@angryermine @lex111
Update content/warnings/invalid-hook-call-warning.md
277b0de 
Co-Authored-By: lex111 <lex61rus@gmail.com>
gcor
gcor reviewed Feb 15, 2019
View reviewed changes
@gcor @lex111
Apply suggestions from code review by @gcor
aa65dc5 
Co-Authored-By: lex111 <lex61rus@gmail.com>
doasync
doasync suggested changes Feb 16, 2019
View reviewed changes
Copy link

@doasync doasync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю некоторые изменения

@another-guy another-guy self-assigned this Feb 17, 2019
@lex111
Copy link
Member Author

lex111 commented Feb 17, 2019

Спасибо @gcor и @doasync за обзор.

@another-guy another-guy removed their assignment Feb 20, 2019
@another-guy another-guy removed the needs review A pull request ready to be reviewed label Feb 20, 2019
@another-guy
Copy link
Collaborator

@lex111 4fde03a поломал CircleCI build. В чём необходимость этих добавленных кавычек?

@lex111
Copy link
Member Author

lex111 commented Feb 20, 2019

@lex111 наоборот, исправил, а поломанный билд из-за того, что есть нарушения оформления кода в других файлах — это уже исправлено, поэтому можно сливать.

@lex111 lex111 merged commit b3975ee into master Feb 20, 2019
@lex111 lex111 deleted the invalid-hook-call-warning branch February 20, 2019 10:52
@lex111
Copy link
Member Author

lex111 commented Feb 20, 2019

Спасибо за ревью @lfedorov, @gcor, @doasync и @another-guy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryermine angryermine angryermine left review comments

@gcor gcor gcor left review comments

@doasync doasync doasync requested changes

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lex111 @another-guy @angryermine @gcor @doasync