Skip to content

Context translation (ready) #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Mar 1, 2019
Merged

Context translation (ready) #164

merged 26 commits into from
Mar 1, 2019

Conversation

egorzekov
Copy link
Contributor

Коллеги, обратите внимание, что изменения в следующих файлах - результат того, что кто-то не запускал yarn check-all перед пул-реквестом:

modified:   gatsby-config.js
modified:   src/components/CodeEditor/CodeEditor.js
modified:   src/components/ErrorDecoder/ErrorDecoder.js
modified:   src/components/LayoutFooter/Footer.js
modified:   src/components/TitleAndMetaTags/TitleAndMetaTags.js
modified:   src/pages/index.js

@tesseralis tesseralis mentioned this pull request Feb 18, 2019
Closed
88 tasks
ntishkevich
ntishkevich reviewed Feb 18, 2019
View reviewed changes
Copy link
Collaborator

@ntishkevich ntishkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 @another-guy @gaearon
Также есть вопрос об использовании «...» в примерах вместо "..." ? Если стоит, то необходимо будет изменить тип кавычек в этом PRе

gcor
gcor reviewed Feb 18, 2019
View reviewed changes
lex111
lex111 reviewed Feb 18, 2019
View reviewed changes
@lex111
Copy link
Member

lex111 commented Feb 18, 2019

@egorzekov отдельное спасибо за напоминание про команду, я сделал коммит сразу в мастер с исправлениями, чтобы в PR были только файлы, которые относятся к переводу.

@lex111
Copy link
Member

lex111 commented Feb 18, 2019

Подключил CI, теперь будем в курсе подобных ошибок 🤖

@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 18, 2019
lex111
lex111 reviewed Feb 19, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Улучшения по коду.

lex111 and others added 20 commits February 19, 2019 17:15
@lex111 @egorzekov
Update examples/context/updating-nested-context-theme-toggler-button.js
25afe93 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update examples/context/motivation-problem.js
b7bfe93 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update content/docs/context.md
6845659 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update examples/context/motivation-problem.js
265983b 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update examples/context/updating-nested-context-app.js
2de5d65 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update examples/context/motivation-problem.js
a278a59 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111 @egorzekov
Update examples/context/motivation-solution.js
82196f9 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
8b4e287 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
a1ef811 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
e905805 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
f7630aa 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
6b9da8e 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
32f49fd 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
59bd18a 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
07085a2 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor @egorzekov
Update content/docs/context.md
d56693a 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
11a023f 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
92e2f55 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
6e56a57 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich @egorzekov
Update content/docs/context.md
cb1a474 
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@netlify
Copy link

netlify bot commented Feb 21, 2019 •
edited
Loading

Deploy preview for ru-reactjs failed.

Built with commit 2286f2d

https://app.netlify.com/sites/ru-reactjs/deploys/5c79a51589adb7000a2dc2b2

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 1, 2019
@another-guy another-guy merged commit b16ec10 into reactjs:master Mar 1, 2019
@another-guy
Copy link
Collaborator

Спасибо за перевод и фиксы, @egorzekov ! 💯

@another-guy another-guy removed their assignment Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryermine angryermine angryermine left review comments

@lex111 lex111 lex111 left review comments

@gcor gcor gcor left review comments

@ntishkevich ntishkevich ntishkevich left review comments

@SmolinPavel SmolinPavel SmolinPavel left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@egorzekov @lex111 @another-guy @angryermine @gcor @ntishkevich @SmolinPavel