Skip to content

Translate React Element Factories and JSX Warning #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2019
Merged

Translate React Element Factories and JSX Warning #31

merged 2 commits into from
Feb 10, 2019

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Feb 9, 2019

Перенёс перевод без изменений из Crowdin - https://crowdin.com/translate/react/1042/en-ru

  • требуется рассмотреть согласование перевода In Depth и занести в словарь.

@lex111 lex111 added work in progress Author opened the pull-request but it's still being worked on from-crowdin This translation came from Crowdin labels Feb 9, 2019
@lex111
Copy link
Member Author

lex111 commented Feb 9, 2019

Эта страница вообще используется, её не нашёл в прогрессе?

@gaearon
Copy link
Member

gaearon commented Feb 10, 2019 •
edited by lex111
Loading

@tesseralis Any reason this page is missing in the template?

@tesseralis
Copy link
Member

I must have forgot it 😓I'll add it and update all the issues

gaearon
gaearon approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

@tesseralis
Copy link
Member

@gaearon Fixed. I misnamed it "legacy-properties" instead!

@lex111 lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 10, 2019
@lex111 lex111 merged commit cace61d into master Feb 10, 2019
@lex111 lex111 deleted the legacy-factories branch February 10, 2019 01:12
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
from-crowdin This translation came from Crowdin needs review A pull request ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lex111 @gaearon @tesseralis