Skip to content

Translate implementation notes #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 10, 2020

Conversation

BogdanDor
Copy link
Contributor

Translate "Implementation notes".

@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for ru-reactjs ready!

Built with commit e2f7c9d

https://deploy-preview-433--ru-reactjs.netlify.com

@BogdanDor BogdanDor mentioned this pull request Nov 14, 2019
88 tasks
Copy link
Contributor

@angryermine angryermine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опечатки

@ntishkevich ntishkevich added the needs review A pull request ready to be reviewed label Nov 22, 2019
Co-Authored-By: Leonid Fedorov <lfedorov@live.com>
Copy link
Collaborator

@gcor gcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо большое за перевод! 👍
Несколько комментариев:

Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@BogdanDor
Copy link
Contributor Author

Во время компиляции markdown в html кавычки поменяются автоматически.

@ntishkevich
Copy link
Collaborator

Во время компиляции markdown в html кавычки поменяются автоматически.

При наличии соответсвующего плагина в gatsby, с которым, кстати, имеются некоторы проблемы при наличии нескольких подряд идущих символов, поэтому, пожалуйста, поменяйте вездена кавычки-ёлочки, чтобы весь markdown файлы имели были в одном виде на случай, если плагин придется отключить. Спасибо.

@gcor
Copy link
Collaborator

gcor commented Feb 6, 2020

@lex111, @ntishkevich получится поревьюить?

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BogdanDor спасибо за перевод, перед тем, как принять пулреквест, можете, пожалуйста, принять предложенные изменения?

BogdanDor and others added 2 commits February 7, 2020 17:02
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@BogdanDor BogdanDor requested a review from lex111 February 7, 2020 14:23
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcor посмотри ещё раз и сливай этот PR.

@gcor gcor merged commit 395465a into reactjs:master Feb 10, 2020
@BogdanDor BogdanDor deleted the implementation-notes-translate branch August 27, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review A pull request ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants