Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persian language #11

Merged
merged 4 commits into from
Feb 9, 2019
Merged

Add Persian language #11

merged 4 commits into from
Feb 9, 2019

Conversation

sorousht
Copy link
Contributor

@sorousht sorousht commented Feb 8, 2019

Hey,

I would like to contribute to the Persian translation. I do not have much experience in translation, but I really enjoy writing some blog posts occasionally.
My previous works:

Please let me find other volunteers before accepting the PR.

@tesseralis
Copy link
Member

@sJJdGG mentioned being interested here: reactjs/react.dev#1605 (comment)

@sorousht
Copy link
Contributor Author

sorousht commented Feb 8, 2019

@sJJdGG May I add you the list of maintainers?

@zahrajoulaei
Copy link

I am glad to working voluntarily on this project, I have been also a volunteer mentor in the Nggirls community which tries to teach Angular to interested women in whole the world, and now I am also looking forward to having this amazing framework in Persian language with the aim of having better access for Persian language people.

@sorousht
Copy link
Contributor Author

sorousht commented Feb 9, 2019

@zahrajoulaei Great to have you onboard!

@sJJdGG
Copy link
Member

sJJdGG commented Feb 9, 2019

@sorousht Yep. count me in already.

@sorousht
Copy link
Contributor Author

sorousht commented Feb 9, 2019

@sJJdGG Perfect! I've just added you :)

@Schabaani
Copy link

Hi dudes,
I am mobile developer and using react-native almost 1 year.
I've started translating react from crowdin.

@tesseralis tesseralis mentioned this pull request Feb 9, 2019
@tesseralis
Copy link
Member

Hi all! You're all set. I added @masoud-bahrami from this issue: #21

Your first assignment: How do I say "yes" and "no" for the translation website: isreacttranslatedyet.com

@tesseralis tesseralis merged commit 6240c89 into reactjs:master Feb 9, 2019
@masoud-bahrami
Copy link
Member

@tesseralis If you're sure about contributors, it's best to link Persian Translation to the site.
For all PR by every contributors It is better to be reviewed by the rest of the members, and if approved, it should be accepted.
Having a dictionary for translated items can also be very helpful.

@tesseralis
Copy link
Member

@sorousht @sJJdGG @zahrajoulaei @Schabaani @masoud-bahrami here's your repo! reactjs/fa.react.dev#1

@SamaneYaghoobi
Copy link

@sorousht I enjoy translating react and just sending the link to beginners who don't know English well :)

@sorousht
Copy link
Contributor Author

sorousht commented Feb 9, 2019

@SamaneYaghoobi Any contribution is welcome! We are in the begining of the way and it would be so much fun :)

@tesseralis
Copy link
Member

Also, let me know if you need any help to get right-to-left text set up! The good thing about working on the repo itself is you can just change any settings to get it to work :)

@yasaminyaldaei
Copy link

Hi, I would be glad to contribute as well! I've started to learn JS and React about 6 months ago and I've used English resources so far. Also I have non-technical translation experience beforehand.

@sorousht
Copy link
Contributor Author

Hi @yasaminyaldaei

Great! We are preparing a contribution guideline document, but here is the workflow in brief:

  • Fork the repo
  • Clone it on your local machine
  • Checkout to fa branch
  • Apply the change and commit
  • Push to [your-username]/fa.reactjs.org
  • Create a merge request from [your-username]:fa to reactjs:fa
  • The merge request will be reviewed by at least 2 maintainers and, then will be merged :)

Please let us know if you have any question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants