Translation of Render Props #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
|
Deploy preview for uk-reactjs ready! Built with commit a83e3d6 |
oleksii-polovyi
requested changes
Apr 19, 2019
There was a problem hiding this comment.
Great start 🚀
Just a few changes from me.
@klymenkoo @mihilbabin please review.
Co-Authored-By: vburlai <vitaly.burlai@gmail.com>
|
All suggestions were applied. I did not know and applied it in one batch, but will use separate batches per person next time (to keep reviewer's name in the commit). I'm not used to this GitHub feature yet. |
vldmrkl
approved these changes
Apr 20, 2019
mihilbabin
suggested changes
Apr 21, 2019
|
@mihilbabin changes applied. Please also see my comment regarding TRANSLATION.md. |
mihilbabin
approved these changes
Apr 22, 2019
|
Thank you guys for review. Hi @ApolllonDev |
oleksii-polovyi
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation of Render Props