Skip to content

Code splitting #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2019
Merged

Code splitting #15

merged 3 commits into from
Feb 18, 2019

Conversation

vtereshyn
Copy link
Contributor

No description provided.

@vtereshyn vtereshyn changed the title Code splitting translation Code splitting Feb 17, 2019
oleksii-polovyi
oleksii-polovyi requested changes Feb 17, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start 👍
Please check my suggestions below.

@oleksii-polovyi
Copy link
Member

@klymenkoo, please review.

vldmrkl
vldmrkl requested changes Feb 18, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за ваш внесок :)
Знайшов кілька помилок, а в цілому гарний початок 👍

@vtereshyn
Copy link
Contributor Author

@klymenkoo , дякую, пофіксив

@vldmrkl
Copy link
Member

vldmrkl commented Feb 18, 2019

@vtereshyn Супер 👍
Дякую за переклад!

@vldmrkl vldmrkl merged commit 9611f6e into reactjs:master Feb 18, 2019
@tesseralis tesseralis mentioned this pull request Feb 18, 2019
Closed
92 tasks
@vtereshyn vtereshyn deleted the i18n/code-splitting branch February 18, 2019 21:56
@mihilbabin
Copy link
Contributor

@klymenkoo тут ще лишилось кілька синтаксичних помилок у словах.

vldmrkl added a commit that referenced this pull request Feb 19, 2019
@vldmrkl
Revert "Code splitting (#15)"
c970139 
This reverts commit 9611f6e.
@vldmrkl vldmrkl mentioned this pull request Feb 19, 2019
Closed
@oleksii-polovyi oleksii-polovyi added Поліпшення New feature or request Баг Something isn't working labels Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihilbabin mihilbabin mihilbabin left review comments

@oleksii-polovyi oleksii-polovyi oleksii-polovyi requested changes

@vldmrkl vldmrkl vldmrkl approved these changes

Assignees

@vtereshyn vtereshyn

Labels
Баг Something isn't working Поліпшення New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtereshyn @oleksii-polovyi @vldmrkl @mihilbabin