Skip to content

chore: translation of 'Using the Effect Hook' section part1 (#74) #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 26, 2020
Merged

chore: translation of 'Using the Effect Hook' section part1 (#74) #152

merged 9 commits into from
Apr 26, 2020

Conversation

oleksii-polovyi
Copy link
Member

@oleksii-polovyi oleksii-polovyi commented Jul 26, 2019 •
edited
Loading

To-Do:

  • finish Part 2 translation

Fixes for #74

  • еффектами - з одною Ф
  • классовими - одна С
  • вимагають => потребують

@oleksii-polovyi oleksii-polovyi requested a review from vldmrkl July 26, 2019 22:47
@oleksii-polovyi oleksii-polovyi self-assigned this Jul 26, 2019
@netlify
Copy link

netlify bot commented Jul 26, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit 033de10

https://deploy-preview-152--uk-reactjs.netlify.app

@oleksii-polovyi oleksii-polovyi added Хуки Hooks part of documentation priority: high labels Jul 27, 2019
liashchynskyi
liashchynskyi suggested changes Aug 6, 2019
View reviewed changes
@oleksii-polovyi oleksii-polovyi removed their assignment Aug 10, 2019
@oleksii-polovyi
Copy link
Member Author

oleksii-polovyi commented Aug 10, 2019 •
edited
Loading

Unfortunately, I won't be able to work on #74 translation until late September.
Therefore, it would be best if someone can finish this PR so I don't slow down the team.

  • finish Part 2 translation

@oleksii-polovyi oleksii-polovyi mentioned this pull request Jan 12, 2020
Closed
92 tasks
@oleksii-polovyi oleksii-polovyi added the Потрібна допомога Extra attention is needed label Jan 12, 2020
@oleksii-polovyi
Copy link
Member Author

@vldmrkl thank you for finishing this one, looks good 🚀

@vldmrkl
Copy link
Member

vldmrkl commented Apr 26, 2020

@AppolllonDev good to merge?

oleksii-polovyi
oleksii-polovyi commented Apr 26, 2020
View reviewed changes
Copy link
Member Author

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes and it should be good 😃

vldmrkl and others added 2 commits April 26, 2020 14:09
@vldmrkl @oleksii-polovyi
Update content/docs/hooks-effect.md
e475708 
Co-Authored-By: Oleksii Polovyi <oleksii.polovyi@gmail.com>
@vldmrkl @oleksii-polovyi
Update content/docs/hooks-effect.md
033de10 
Co-Authored-By: Oleksii Polovyi <oleksii.polovyi@gmail.com>
@vldmrkl vldmrkl merged commit 9e81689 into master Apr 26, 2020
@vldmrkl vldmrkl deleted the 74-fix branch April 26, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liashchynskyi liashchynskyi liashchynskyi approved these changes

@vldmrkl vldmrkl vldmrkl approved these changes

Assignees

@vldmrkl vldmrkl

Labels
Потрібна допомога Extra attention is needed Хуки Hooks part of documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksii-polovyi @vldmrkl @liashchynskyi