Skip to content

Translation of reference-react-dom.md #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2019
Merged

Translation of reference-react-dom.md #38

merged 6 commits into from
Mar 10, 2019

Conversation

Kiwka
Copy link
Contributor

@Kiwka Kiwka commented Feb 27, 2019

This PR is containing translation for the ReactDOM chapter from English to Ukrainian

@netlify
Copy link

netlify bot commented Feb 27, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit 6fc4b79

https://deploy-preview-38--uk-reactjs.netlify.com

liashchynskyi
liashchynskyi suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@liashchynskyi liashchynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klymenkoo @ApolllonDev @mihilbabin ваша черга)) загалом, формулювання деяких речень бажає кращого))

@mihilbabin
Copy link
Contributor

mihilbabin commented Feb 27, 2019 •
edited
Loading

@Kiwka, нода - вузол, контент - вміст. Переіменуйте скрізь, будь ласка.

oleksii-polovyi
oleksii-polovyi requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 👍
Please fix the suggestions from @mihilbabin and @liashchynskyi.

@mihilbabin
Copy link
Contributor

@Kiwka, позначте, будь ласка, як resolved, все що виправлено і я зроблю final pass:)

@vldmrkl vldmrkl added Просунуті Теми Advanced Guides part of documentation API-довідка API Reference part of documentation priority: high and removed Просунуті Теми Advanced Guides part of documentation labels Mar 2, 2019
vldmrkl
vldmrkl requested changes Mar 2, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за переклад @Kiwka :) Треба зробити кілька виправлень.

@Kiwka
Copy link
Contributor Author

Kiwka commented Mar 9, 2019

Ready for next round

mihilbabin
mihilbabin suggested changes Mar 9, 2019
View reviewed changes
vldmrkl
vldmrkl requested changes Mar 10, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ще одне маленьке виправлення треба зробити :)

@vldmrkl
Copy link
Member

vldmrkl commented Mar 10, 2019

@Kiwka дякую за переклад 🙌

@vldmrkl vldmrkl merged commit 69b7a93 into reactjs:master Mar 10, 2019
@tesseralis tesseralis mentioned this pull request Mar 10, 2019
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kurzdor Kurzdor Kurzdor left review comments

@oleksii-polovyi oleksii-polovyi oleksii-polovyi requested changes

@liashchynskyi liashchynskyi liashchynskyi requested changes

@mihilbabin mihilbabin mihilbabin approved these changes

@vldmrkl vldmrkl vldmrkl approved these changes

Assignees

@Kiwka Kiwka

Labels
API-довідка API Reference part of documentation priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kiwka @mihilbabin @vldmrkl @oleksii-polovyi @liashchynskyi @Kurzdor