Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cn): translate content/docs/reference-dom-elements.md into Chinese #105

Merged
merged 9 commits into from
Mar 15, 2019
Merged

docs(cn): translate content/docs/reference-dom-elements.md into Chinese #105

merged 9 commits into from
Mar 15, 2019

Conversation

zbc
Copy link
Contributor

@zbc zbc commented Feb 17, 2019

Added translation for DOM Elements.

@zbc zbc changed the title Pr/dom elements docs(cn): translate content/docs/reference-dom-elements.md into Chinese Feb 17, 2019
@QC-L QC-L added the Pending Review 已翻译，待校对阶段 label Feb 17, 2019
@QC-L QC-L mentioned this pull request Feb 17, 2019
Closed
@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for cn-reactjs ready!

Built with commit 354864e

https://deploy-preview-105--cn-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for zh-hans-reactjs ready!

Built with commit 354864e

https://deploy-preview-105--zh-hans-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 7, 2019 •
edited
Loading

Deploy preview for cn-reactjs ready!

Built with commit 5c77fd8

https://deploy-preview-105--cn-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 7, 2019 •
edited
Loading

Deploy preview for zh-hans-reactjs ready!

Built with commit 5c77fd8

https://deploy-preview-105--zh-hans-reactjs.netlify.com

QC-L
QC-L requested changes Mar 12, 2019
View reviewed changes
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@QC-L @zbc
Apply suggestions and update translations
24c91e3 
Co-Authored-By: zbc <zhaobocong@hotmail.com>
@QC-L QC-L added Pending Modify 已校对，待修改阶段 Pending Re-Review 已修改，待审校阶段 and removed Pending Review 已翻译，待校对阶段 Pending Modify 已校对，待修改阶段 labels Mar 12, 2019
jothy1023
jothy1023 requested changes Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@jothy1023 jothy1023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

觉得这些地方都改过来就可以啦～～辛苦译者，质量很棒～

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
QC-L
QC-L previously approved these changes Mar 14, 2019
View reviewed changes
@cyan33
Copy link
Collaborator

cyan33 commented Mar 14, 2019

Hey @zbc, added some nitpicks. Other than that, awesome translation. Good job. 👍

cc @hijiangtao @QC-L @fonkie

@QC-L QC-L added Pending Modify 已校对，待修改阶段 and removed Pending Re-Review 已修改，待审校阶段 labels Mar 14, 2019
@fonkie fonkie added Pending Re-Review 已修改，待审校阶段 and removed Pending Modify 已校对，待修改阶段 labels Mar 14, 2019
hijiangtao
hijiangtao approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@hijiangtao hijiangtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hijiangtao hijiangtao requested a review from jothy1023 March 14, 2019 17:30
QC-L
QC-L approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@QC-L QC-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jothy1023
jothy1023 approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@jothy1023 jothy1023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 👍

@QC-L QC-L merged commit 72988ac into reactjs:master Mar 15, 2019
OhIAmFine pushed a commit to OhIAmFine/zh-hans.reactjs.org that referenced this pull request May 6, 2019
@zbc @QC-L
docs(cn): translate content/docs/reference-dom-elements.md into Chine…
9fdd0de 
…se (reactjs#105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyan33 cyan33 cyan33 left review comments

@hijiangtao hijiangtao hijiangtao approved these changes

@QC-L QC-L QC-L approved these changes

@jothy1023 jothy1023 jothy1023 approved these changes

Assignees
No one assigned
Labels
Pending Re-Review 已修改，待审校阶段
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zbc @cyan33 @hijiangtao @QC-L @jothy1023 @fonkie