Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta]: docs(cn): state-a-components-memory #651

Merged
merged 11 commits into from
Feb 28, 2023
Merged

[Beta]: docs(cn): state-a-components-memory #651

merged 11 commits into from
Feb 28, 2023

Conversation

zzwgh
Copy link
Contributor

@zzwgh zzwgh commented Nov 8, 2021

No description provided.

@github-actions github-actions bot added the beta label Nov 8, 2021
@zzwgh zzwgh changed the title [Beta] docs(cn): state-a-components-memory [Beta]: docs(cn): state-a-components-memory Nov 8, 2021
@zzwgh zzwgh mentioned this pull request Nov 8, 2021
Open
@QC-L QC-L mentioned this pull request Dec 7, 2021
Closed
x-cold
x-cold reviewed Dec 19, 2021
View reviewed changes
@awxiaoxian2020 awxiaoxian2020 added Pending Modify 已校对，待修改阶段 need adjust structure 内容结构已过时，需要调整 and removed Pending Modify 已校对，待修改阶段 labels Feb 14, 2023
@awxiaoxian2020 awxiaoxian2020 mentioned this pull request Feb 16, 2023
Closed
@github-actions
Copy link

github-actions bot commented Feb 23, 2023 •
edited
Loading

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@awxiaoxian2020
Copy link
Collaborator

awxiaoxian2020 commented Feb 23, 2023 •
edited
Loading

Do you consider applying code review or looking into it?

Or you have done these changes?

@awxiaoxian2020 awxiaoxian2020 added Pending Modify 已校对，待修改阶段 and removed need adjust structure 内容结构已过时，需要调整 labels Feb 23, 2023
@awxiaoxian2020 awxiaoxian2020 removed the Pending Modify 已校对，待修改阶段 label Feb 24, 2023
@awxiaoxian2020 awxiaoxian2020 added the Pending Re-Review 已修改，待审校阶段 label Feb 24, 2023
@zzwgh
Copy link
Contributor Author

zzwgh commented Feb 24, 2023

Do you consider applying code review or looking into it?

Or you have done these changes?

last round of conversations are resolved. maybe need some more review on it.

daochouwangu
daochouwangu requested changes Feb 27, 2023
View reviewed changes
@awxiaoxian2020 @daochouwangu
Apply suggestions from code review
10e054a 
Co-authored-by: TimLi <daochouwangu@gmail.com>
@awxiaoxian2020 @daochouwangu
Update beta/src/content/learn/state-a-components-memory.md
8ff5f1c 
Co-authored-by: TimLi <daochouwangu@gmail.com>
@awxiaoxian2020 awxiaoxian2020 merged commit f9953dc into reactjs:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-cold x-cold x-cold left review comments

@KnowsCount KnowsCount KnowsCount left review comments

@daochouwangu daochouwangu daochouwangu approved these changes

@awxiaoxian2020 awxiaoxian2020 awxiaoxian2020 approved these changes

Assignees
No one assigned
Labels
beta Pending Re-Review 已修改，待审校阶段
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zzwgh @awxiaoxian2020 @daochouwangu @x-cold @KnowsCount