Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] docs(cn): add writing-markup-with-jsx #673

Merged
merged 21 commits into from
May 27, 2022

Conversation

songhn233
Copy link
Contributor

@QC-L For #614.

Copy link
Contributor

@fqd511 fqd511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充了一些我觉得可能更合适的表达,外加部分锚点

beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
Co-authored-by: 511 <fqd511@163.com>
songhn233 and others added 6 commits December 6, 2021 23:43
Co-authored-by: 511 <fqd511@163.com>
Co-authored-by: 511 <fqd511@163.com>
Co-authored-by: 511 <fqd511@163.com>
songhn233 and others added 2 commits December 6, 2021 23:51
@songhn233
Copy link
Contributor Author

补充了一些我觉得可能更合适的表达,外加部分锚点

感谢 review,剩下的几处我觉得没有修改的必要。如果没有异议的话我标记为 resolve 了?

@fqd511
Copy link
Contributor

fqd511 commented Dec 7, 2021

ok的

@QC-L QC-L mentioned this pull request Dec 7, 2021
songhn233 and others added 3 commits February 8, 2022 15:32
Co-authored-by: KnowsCount <knowscount@gmail.com>
Co-authored-by: KnowsCount <knowscount@gmail.com>
Co-authored-by: KnowsCount <knowscount@gmail.com>
KnowsCount
KnowsCount previously approved these changes Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Feb 10, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/writing-markup-with-jsx 51.88 KB (🟡 +954 B) 136.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

fqd511
fqd511 previously approved these changes Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants