Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] docs(cn): translate render-and-commit into Chinese #686

Merged
merged 9 commits into from
Jan 19, 2022
Merged

[Beta] docs(cn): translate render-and-commit into Chinese #686

merged 9 commits into from
Jan 19, 2022

Conversation

oceanlvr
Copy link
Contributor

@oceanlvr oceanlvr commented Dec 8, 2021

No description provided.

@github-actions github-actions bot added the beta label Dec 8, 2021
@oceanlvr oceanlvr changed the title docs: translate render-and-commit into Chinese [Beta] docs(cn): translate render-and-commit into Chinese Dec 8, 2021
@oceanlvr oceanlvr mentioned this pull request Dec 8, 2021
Open
@yyyanghj yyyanghj mentioned this pull request Dec 17, 2021
Closed
KimYangOfCat
KimYangOfCat reviewed Dec 31, 2021
View reviewed changes
Copy link
Contributor

@KimYangOfCat KimYangOfCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译很好，赞！

beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
@oceanlvr @KimYangOfCat
Apply suggestions from code review
97a827b 
Co-authored-by: Kim Yang <Kim.Yang.GH@outlook.com>
@oceanlvr
Copy link
Contributor Author

@KimYangOfCat 感谢您的 review，辛苦了～

Neo42
Neo42 reviewed Jan 1, 2022
View reviewed changes
Copy link
Contributor

@Neo42 Neo42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完毕，麻烦处理一下 @oceanlvr

beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Show resolved Hide resolved
@oceanlvr @KimYangOfCat @Neo42
Apply suggestions from code review
ab0dd39 
Co-authored-by: Kim Yang <Kim.Yang.GH@outlook.com>
Co-authored-by: Hao Jiang ᛋ <22409868+Neo42@users.noreply.github.com>
@oceanlvr @Neo42
Apply suggestions from code review
fca6cae 
Co-authored-by: Hao Jiang ᛋ <22409868+Neo42@users.noreply.github.com>
@oceanlvr
Copy link
Contributor Author

oceanlvr commented Jan 6, 2022 •
edited
Loading

@Neo42 @KimYangOfCat 感谢两位大佬的翻译，特别是 Neo42，指出了大量翻译错误，谢谢你们！

还请麻烦两位大佬看下现在这个版本怎么样了。

Neo42
Neo42 previously approved these changes Jan 6, 2022
View reviewed changes
@oceanlvr
Copy link
Contributor Author

oceanlvr commented Jan 9, 2022

@KimYangOfCat 如果没问题请 approve 这个 PR～

KimYangOfCat
KimYangOfCat previously approved these changes Jan 9, 2022
View reviewed changes
@oceanlvr @KnowsCount
Update beta/src/pages/learn/render-and-commit.md
5f1902a 
Co-authored-by: KnowsCount <knowscount@gmail.com>
@oceanlvr oceanlvr dismissed stale reviews from KimYangOfCat and Neo42 via 5f1902a January 11, 2022 11:13
Neo42
Neo42 previously approved these changes Jan 15, 2022
View reviewed changes
TinaaaaP
TinaaaaP reviewed Jan 15, 2022
View reviewed changes
Copy link
Contributor

@TinaaaaP TinaaaaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for the overall flow. Really good translation so far!

beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
@oceanlvr @TinaaaaP
Apply suggestions from code review
5ee6f9e 
Co-authored-by: Tina Pu <t2pu@uwaterloo.ca>
@oceanlvr
Copy link
Contributor Author

@QC-L PTAL!

@QC-L QC-L merged commit 9f09ed7 into reactjs:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaaaaP TinaaaaP TinaaaaP left review comments

@KnowsCount KnowsCount KnowsCount left review comments

@Neo42 Neo42 Neo42 approved these changes

@QC-L QC-L QC-L approved these changes

@KimYangOfCat KimYangOfCat KimYangOfCat left review comments

Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oceanlvr @QC-L @Neo42 @KimYangOfCat @KnowsCount @TinaaaaP