Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest official SWT releases from Maven Central #216

Closed
simonbasle opened this issue Nov 15, 2019 · 3 comments
Closed

Switch to latest official SWT releases from Maven Central #216

simonbasle opened this issue Nov 15, 2019 · 3 comments
Labels
area/reactor-extra This belongs to the reactor-extra module status/declined We feel we shouldn't currently apply this change/suggestion

Comments

@simonbasle
Copy link
Member

simonbasle commented Nov 15, 2019

SWT has started being officially distributed to Maven Central as of early 2017.
As a result, https://maven-eclipse.github.io/maven has not been updated in a while, and the build is currently outdated.

We could switch to latest SWT distribution using the swt platform, which allows us to declare a dependency to an OS-independent artifact (which in turn declares a dependency to ${osgi.platform}-dependent jar).

For compilation purposes, the osgi.plaftform must be substituted with a locally-relevant os-specific jar, like so:

	configurations.all {
		resolutionStrategy {
			dependencySubstitution {
				// The maven property ${osgi.platform} is not handled by Gradle
				// so we replace the dependency, using the osgi platform from the project settings
				substitute module('org.eclipse.platform:org.eclipse.swt.${osgi.platform}') with module("org.eclipse.platform:org.eclipse.swt.${getSwtPlatform()}:${swtVersionPlatform}")
			}
		}
	}


	dependencies {
		optional "org.eclipse.platform:org.eclipse.swt:${swtVersionPlatform}"
	}

Latest swtVersionPlatform is 3.112.0. Notice the official Maven Central groupId is org.eclipse.platform.

@simonbasle simonbasle added type/enhancement A general enhancement ❓need-triage This issue needs triage, hasn't been looked at by a team member yet area/reactor-extra This belongs to the reactor-extra module for/team-attention This issue needs team attention or action status/need-decision This needs a decision from the team warn/api-change Breaking change with compilation errors and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Nov 15, 2019
@simonbasle
Copy link
Member Author

api-change: not really API per-se, but the dependency to SWT would change.

@simonbasle
Copy link
Member Author

simonbasle commented Nov 15, 2019

⚠️ The same type of change would be necessary in https://github.com/reactor/reactor-kotlin-extensions !

@simonbasle simonbasle added this to the 3.5 planning milestone Jan 7, 2021
@simonbasle
Copy link
Member Author

superseded by #273

@simonbasle simonbasle removed this from the 3.5.0 planning milestone Mar 7, 2022
@simonbasle simonbasle added status/declined We feel we shouldn't currently apply this change/suggestion and removed type/enhancement A general enhancement warn/api-change Breaking change with compilation errors status/need-decision This needs a decision from the team for/team-attention This issue needs team attention or action labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reactor-extra This belongs to the reactor-extra module status/declined We feel we shouldn't currently apply this change/suggestion
Projects
None yet
Development

No branches or pull requests

1 participant