Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating reactor-extra's Swing/SwtScheduler (removal in 3.6.0) #273

Closed
3 tasks
simonbasle opened this issue Feb 28, 2022 · 2 comments · Fixed by #277
Closed
3 tasks

Deprecating reactor-extra's Swing/SwtScheduler (removal in 3.6.0) #273

simonbasle opened this issue Feb 28, 2022 · 2 comments · Fixed by #277
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Milestone
3.4.7

Comments

@simonbasle
Copy link
Member

simonbasle commented Feb 28, 2022 •
edited
Loading

Motivation

The SwingScheduler and SwtScheduler adapters don't seem to have much traction, as far as we're aware.
The SWT one is using outdated SWT libraries and complexifies the build infrastructure for little gain.

(for instance, searching for reactor.swing.SwingScheduler results in 2 code hits in all of GitHub. The other one gets 3 hits total...)

Deprecation and removal plan

  1. Deprecation in 3.4.7 (estimated early March 2022)
  2. Removal in 3.6.0 (no planned date, probably late 2023 or late 2024)
    2. Removal in 3.5.0 (estimated last quarter of 2022) (see comment below)

Additional steps
@simonbasle simonbasle added type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations labels Feb 28, 2022
@simonbasle simonbasle added this to the 3.4.7 milestone Feb 28, 2022
@simonbasle simonbasle mentioned this issue Feb 28, 2022
Closed
@vogella
Copy link

vogella commented Feb 28, 2022

A have a client using the SWTScheduler but we copied the scheduler over to our code base to compile against the right SWT libraries, so removal in this project would be fine for us.

This was referenced Mar 7, 2022
Closed
Merged
@simonbasle
Copy link
Member Author

Note: despite the low criticality of these adapters, we might want to avoid making any exceptions to our deprecation policy, so technically this would be removable in 3.6.0 at the earliest (and we definitely won't keep it past that).

@simonbasle simonbasle changed the title Deprecating reactor-extra's Swing/SwtScheduler (removal in 3.5.0) Deprecating reactor-extra's Swing/SwtScheduler (removal in 3.6.0) Mar 11, 2022
This was referenced Mar 11, 2022
Closed
Merged
Open
simonbasle added a commit to reactor/reactor-kotlin-extensions that referenced this issue Mar 11, 2022
@simonbasle
Deprecate SwtScheduler extension for removal in 3.5.0 (#39)
989d82c 
This commit marks the SWT extension as deprecated, mirroring the
deprecation in reactor-extra (see reactor/reactor-addons#273).

Unlike in addons where the code is a bit more involved, the extension
is a single line of code. It adds some complexity to the build to
select the SWT variant, and adds a dependency (which is a bit dated).

As a result, exceptionally, we are going to remove it in 1.2.0 instead
of 1.3.0. Any dependency to SWT would also be removed from this project
at that point.

Fixes #38.
simonbasle added a commit to reactor/reactor-core that referenced this issue Mar 11, 2022
@simonbasle
[guide] Remove ref to Swing/SwtScheduler in addons appendix (#2959)
5e5917b 
See reactor/reactor-addons#273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Milestone
3.4.7
Development

Successfully merging a pull request may close this issue.

Deprecate Swt/Swing addons, to be removed in 3.6.0 reactor/reactor-addons
2 participants
@vogella @simonbasle