Skip to content

Commit

Permalink
[build] Fix tagging step, using job's output
Browse files Browse the repository at this point in the history
The tag name is derived from prepare job's output, not a previous
step (that doesn't exist in this job)...
  • Loading branch information
simonbasle committed May 11, 2021
1 parent d1138d8 commit 7d5ab08
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
runs-on: ubuntu-20.04
outputs:
versionType: ${{ steps.version.outputs.versionType }}
fullVersion: ${{ steps.version.outputs.fullVersion }}
steps:
- uses: actions/checkout@v2
- name: setup java
Expand Down Expand Up @@ -73,7 +74,7 @@ jobs:
run: |
git config --local user.name 'reactorbot'
git config --local user.email '32325210+reactorbot@users.noreply.github.com'
git tag -m "Release milestone ${{ steps.version.outputs.fullVersion }}" v${{ steps.version.outputs.fullVersion }} ${{ github.sha }}
git tag -m "Release milestone ${{ needs.prepare.outputs.fullVersion }}" v${{ needs.prepare.outputs.fullVersion }} ${{ github.sha }}
git push --tags
#sign the release artifacts and deploy them to Artifactory
Expand Down Expand Up @@ -102,7 +103,7 @@ jobs:
run: |
git config --local user.name 'reactorbot'
git config --local user.email '32325210+reactorbot@users.noreply.github.com'
git tag -m "Release version ${{ steps.version.outputs.fullVersion }}" v${{ steps.version.outputs.fullVersion }} ${{ github.sha }}
git tag -m "Release version ${{ needs.prepare.outputs.fullVersion }}" v${{ needs.prepare.outputs.fullVersion }} ${{ github.sha }}
git push --tags
# For Gradle configuration of signing, see https://docs.gradle.org/current/userguide/signing_plugin.html#sec:in-memory-keys
Expand Down

0 comments on commit 7d5ab08

Please sign in to comment.