[build] Move the tagging step last

See reactor/reactor#699.
reactor · May 11, 2021 · b65019c · b65019c
1 parent 29d2e3b
commit b65019c
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -29,13 +29,6 @@ jobs:
     - name: run checks
       id: checks
       run: ./gradlew check
-    - name: tag
-      if: steps.version.outputs.versionType == 'RELEASE' || steps.version.outputs.versionType == 'MILESTONE'
-      run: |
-        git config --local user.name 'reactorbot'
-        git config --local user.email '32325210+reactorbot@users.noreply.github.com'
-        git tag -m "Release version ${{ steps.version.outputs.fullVersion }}" v${{ steps.version.outputs.fullVersion }} ${{ github.sha }}
-        git push --tags
 
   #deploy the snapshot artifacts to Artifactory
   deploySnapshot:
@@ -76,6 +69,12 @@ jobs:
         ORG_GRADLE_PROJECT_signingPassword: ${{secrets.SIGNING_PASSPHRASE}}
       run: |
           ./gradlew assemble sign artifactoryPublish -Partifactory_publish_contextUrl=https://repo.spring.io -Partifactory_publish_repoKey=libs-milestone-local
+    - name: tag
+      run: |
+        git config --local user.name 'reactorbot'
+        git config --local user.email '32325210+reactorbot@users.noreply.github.com'
+        git tag -m "Release milestone ${{ steps.version.outputs.fullVersion }}" v${{ steps.version.outputs.fullVersion }} ${{ github.sha }}
+        git push --tags
 
   #sign the release artifacts and deploy them to Artifactory
   deployRelease:
@@ -99,6 +98,12 @@ jobs:
         ORG_GRADLE_PROJECT_sonatypePassword: ${{secrets.SONATYPE_PASSWORD}}
       run: |
           ./gradlew assemble sign artifactoryPublish -Partifactory_publish_contextUrl=https://repo.spring.io  -Partifactory_publish_repoKey=libs-release-local publishMavenJavaPublicationToSonatypeRepository
+    - name: tag
+      run: |
+        git config --local user.name 'reactorbot'
+        git config --local user.email '32325210+reactorbot@users.noreply.github.com'
+        git tag -m "Release version ${{ steps.version.outputs.fullVersion }}" v${{ steps.version.outputs.fullVersion }} ${{ github.sha }}
+        git push --tags
 
 # For Gradle configuration of signing, see https://docs.gradle.org/current/userguide/signing_plugin.html#sec:in-memory-keys
 # publishMavenJavaPublicationToSonatypeRepository only sends to a staging repository