-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Call init() on delegate from TimedScheduler (#3876)
The `TimedScheduler` class doesn't currently provide an override for the `init()` method, which means it calls the default implementation on the interface that delegates to `start()`. Most existing schedulers have an implementation of `start()` and it's not a problem for them. However, the newer `BoundedElasticThreadPerTaskScheduler` throws an error for `start()`, so wrapping it in a `TimedScheduler` causes it to crash immediately when `init()` gets called. With this change, the wrapped scheduler's `init()` method is called instead and allows users to get metrics for the virtual thread schedulers. --------- Co-authored-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
- Loading branch information
1 parent
63d25e9
commit b732811
Showing
2 changed files
with
59 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters