Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Flux.create" example #3600

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix "Flux.create" example #3600

merged 1 commit into from
May 24, 2024

Conversation

pivovarit
Copy link
Contributor

The example used the old timeout() method with the number of seconds as a parameter.

Replaced it with the new method accepting a Duration object.

@pivovarit
Fix "Flux.create" example
b5518d5 
The example used old `timeout()` method with a number of seconds as a parameter. Replaced it with the new method accepting a `Duration` object.
@pivovarit pivovarit requested a review from a team as a code owner October 3, 2023 06:56
chemicL
chemicL approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. just for the record: I checked the old Javadocs and I feel there never was a timeout(Integer) method so this was just a mistake all along.

@chemicL chemicL added the type/documentation A documentation update label May 24, 2024
@chemicL chemicL added this to the 3.7.0-M3 milestone May 24, 2024
@chemicL chemicL merged commit 962aeb7 into reactor:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemicL chemicL chemicL approved these changes

Assignees
No one assigned
Labels
type/documentation A documentation update
Projects
None yet
Milestone
3.7.0-M3
Development

Successfully merging this pull request may close these issues.
2 participants
@pivovarit @chemicL