-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RetryBackoffSpec Multiplier configurable #3603
Conversation
Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
… multiplier in RetryBackoffSpec Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
…ry multiplier. Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
Hey, @iain-henderson . I realize this proposal has not gained the attention that it's due. Please accept our apologies. Do you still consider making some progress on this PR? It looks almost complete. What I am missing is a test that validates the multiplier is in fact used to calculate properly next values and they're following the expected pattern. Let me know if you'd like to get this in, thanks. |
That’s a reasonable, sensible test to add. I’ll see what I can do. |
@iain-henderson it's been a month. As I was not allowed to add commits to your repository I opened a new PR with your changes together with a test: #3883. Closing this one. Thanks for the contribution! |
Thank you for taking care of that for me... life suddenly got busier than usual. |
@iain-henderson no worries at all. Thanks again for the effort, all the best! |
A small change to make the base of the exponential backoff calculation (the multiplier) configurable.
This is similar to how spring-rety is configured.