Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RetryBackoffSpec Multiplier configurable #3603

Closed
wants to merge 6 commits into from

Conversation

iain-henderson
Copy link
Contributor

A small change to make the base of the exponential backoff calculation (the multiplier) configurable.

This is similar to how spring-rety is configured.

iain-henderson and others added 5 commits September 29, 2023 15:37
Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
… multiplier in RetryBackoffSpec

Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
…ry multiplier.

Signed-off-by: Iain Henderson <Iain.henderson@mac.com>
@iain-henderson iain-henderson requested a review from a team as a code owner October 3, 2023 12:13
@chemicL
Copy link
Member

chemicL commented Jul 23, 2024

Hey, @iain-henderson . I realize this proposal has not gained the attention that it's due. Please accept our apologies. Do you still consider making some progress on this PR? It looks almost complete. What I am missing is a test that validates the multiplier is in fact used to calculate properly next values and they're following the expected pattern. Let me know if you'd like to get this in, thanks.

@chemicL chemicL added type/enhancement A general enhancement status/need-user-input This needs user input to proceed labels Jul 23, 2024
@iain-henderson
Copy link
Contributor Author

That’s a reasonable, sensible test to add. I’ll see what I can do.

@chemicL
Copy link
Member

chemicL commented Aug 26, 2024

@iain-henderson it's been a month. As I was not allowed to add commits to your repository I opened a new PR with your changes together with a test: #3883. Closing this one. Thanks for the contribution!

@chemicL chemicL closed this Aug 26, 2024
@chemicL chemicL removed the status/need-user-input This needs user input to proceed label Aug 26, 2024
@iain-henderson
Copy link
Contributor Author

Thank you for taking care of that for me... life suddenly got busier than usual.

@chemicL
Copy link
Member

chemicL commented Aug 27, 2024

@iain-henderson no worries at all. Thanks again for the effort, all the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants