-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3772: wrapped with await().untilAsserted
#3779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I think it's a good approach. Please rebase to target the 3.6.x branch and let's merge it 🚀
55ad51d
to
fe2b1f9
Compare
@chemicL Thanks for your comment 🙇♂️ $ git remote add upstream https://github.com/reactor/reactor-core.git
$ git checkout -b 3.6.x upstream/3.6.x
$ git checkout 240330-test-fix
$ git rebase 3.6.x # conflict occurs at gradle.properties (i resolved it)
$ git push --force |
Thanks! I changed the base and I think there won't be any issue, but next time consider using |
I see. thanks for your kindful comments 🙇♂️ |
Thank you for the contribution @chickenchickenlove 🚀 |
Wrapped
Assertions.assertThat(disposable.isDisposed()).isTrue()
withAwaitility.await()
.Because
disposable.dispose()
is not finished yet right after latch reaches zero.Fixes #3772