Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Document when groupBy can deadlock because of backpressure #3872

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

NamrataGuptaRoy
Copy link
Contributor

Adds documentation for the 4 groupBy overloads about the scenario where backpressure can cause a deadlock with groupBy and suggesting how it could be avoided.
Adds example of deadlock with groupBy and concatMap in the reference documentation.

See #3443

@NamrataGuptaRoy NamrataGuptaRoy requested a review from a team as a code owner August 15, 2024 08:50
@pivotal-cla
Copy link

@NamrataGuptaRoy Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@NamrataGuptaRoy Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@NamrataGuptaRoy Thank you for signing the Contributor License Agreement!

@NamrataGuptaRoy NamrataGuptaRoy changed the title [doc] Document when groupBy can deadlock because of backpressure (See #3443) [doc] Document when groupBy can deadlock because of backpressure Aug 15, 2024
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have some formatting and style remarks but I'll add them as a separate commit.

@chemicL chemicL added the type/documentation A documentation update label Aug 20, 2024
@chemicL chemicL added this to the 3.7.0-M6 milestone Aug 20, 2024
@chemicL chemicL merged commit bd04464 into reactor:main Aug 20, 2024
7 checks passed
chemicL added a commit that referenced this pull request Aug 20, 2024
@chemicL
Copy link
Member

chemicL commented Aug 20, 2024

@NamrataGuptaRoy ef152df contains my alterations - mostly formatting and styling. One thing I wanted to clarify was the notion of consumption rate. I believe that term would have been misleading, as the rate didn't have any significance in the scenarios provided - it was the consumption pattern (concurrency too low) that prevented progress. The rate could have been enormous and nothing would have changed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document when groupBy can deadlock because of beckpressure
3 participants