-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Document when groupBy can deadlock because of backpressure #3872
Conversation
…eactor#3443) This documents the scenarios where backpressure can lead to deadlock in groupBy and how it could be avoided.
@NamrataGuptaRoy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
1 similar comment
@NamrataGuptaRoy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@NamrataGuptaRoy Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have some formatting and style remarks but I'll add them as a separate commit.
@NamrataGuptaRoy ef152df contains my alterations - mostly formatting and styling. One thing I wanted to clarify was the notion of consumption rate. I believe that term would have been misleading, as the rate didn't have any significance in the scenarios provided - it was the consumption pattern (concurrency too low) that prevented progress. The rate could have been enormous and nothing would have changed :) |
Adds documentation for the 4 groupBy overloads about the scenario where backpressure can cause a deadlock with groupBy and suggesting how it could be avoided.
Adds example of deadlock with groupBy and concatMap in the reference documentation.
See #3443