Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1478 Schedule the first channel.read() once the HttpHeaders are sent #1480

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

violetagg
Copy link
Member

There are use cases when the target server may want to reject the incoming
request immediately and to close the connection. Instead of scheduling
the first channel.read() when the request body is sent, the first channel.read()
will be scheduled once the HttpHeaders are sent.

Fixes #1478

…sent

There are use cases when the target server may want to reject the incoming
request immediately and to close the connection. Instead of scheduling
the first channel.read() when the request body is sent, the first channel.read()
will be scheduled once the HttpHeaders are sent.
@violetagg violetagg added this to the 1.0.4 milestone Jan 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #1480 (3f997c0) into master (b05b235) will increase coverage by 0.02%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1480      +/-   ##
============================================
+ Coverage     70.94%   70.97%   +0.02%     
- Complexity     1888     1892       +4     
============================================
  Files           146      146              
  Lines          9288     9294       +6     
  Branches       1269     1271       +2     
============================================
+ Hits           6589     6596       +7     
+ Misses         2040     2038       -2     
- Partials        659      660       +1     
Impacted Files Coverage Δ Complexity Δ
...tor/netty/http/client/FailedHttpClientRequest.java 36.66% <0.00%> (-3.34%) 5.00 <0.00> (ø)
...c/main/java/reactor/netty/http/HttpOperations.java 70.30% <100.00%> (+0.18%) 43.00 <1.00> (+1.00)
...eactor/netty/http/client/HttpClientOperations.java 68.00% <100.00%> (+0.32%) 90.00 <2.00> (+2.00)
...eactor/netty/http/server/HttpServerOperations.java 74.65% <100.00%> (-0.27%) 77.00 <1.00> (ø)
...r/netty/transport/AddressResolverGroupMetrics.java 29.62% <0.00%> (-7.41%) 2.00% <0.00%> (ø%)
.../reactor/netty/http/server/HttpTrafficHandler.java 80.55% <0.00%> (-1.39%) 55.00% <0.00%> (-1.00%)
...tor/netty/http/client/Http2ConnectionProvider.java 83.80% <0.00%> (-0.48%) 11.00% <0.00%> (ø%)
...va/reactor/netty/http/client/HttpClientConfig.java 79.59% <0.00%> (+0.33%) 41.00% <0.00%> (+1.00%)
.../main/java/reactor/netty/channel/MonoSendMany.java 59.02% <0.00%> (+0.61%) 12.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c651c...3f997c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form-data Connection has been closed BEFORE response, while sending request body
3 participants